@@ -77,7 +77,7 @@ Show info about the app like the web url, git repo, and sharing settings. Update settings on the app, providing one or more of the options shown. - heroku sharing --add <email> --access (edit|view) + heroku sharing --add <email> heroku sharing --remove <email> Manage collaborators on the app. An invitation will be sent by email for the README @@ -47,12 +47,10 @@ Update app settings, with input structure matching the output of the GET above. GET http://heroku.com/apps/:appname/collaborators -Returns XML list of collaborators (email addresses) on the app, including the -edit/view access setting for each. +Returns XML list of collaborators (email addresses) on the app POST http://heroku.com/apps/:appname/collaborators collaborator[email]=:email - collaborator[access]=(edit|view) Add a new collaborator to the app. REST @@ -59,12 +59,11 @@ class Heroku::Client delete("/apps/#{name}") end - # Get a list of collaborators on the app, returns an array of hashes each of - # which contain :email and :access (=> edit | view) elements. + # Get a list of collaborators on the app, returns an array of hashes each with :email def list_collaborators(app_name) doc = xml(get("/apps/#{app_name}/collaborators")) doc.elements.to_a("//collaborators/collaborator").map do |a| - { :email => a.elements['email'].text, :access => a.elements['access'].text } + { :email => a.elements['email'].text } end end @@ -73,11 +72,6 @@ class Heroku::Client xml(post("/apps/#{app_name}/collaborators", { 'collaborator[email]' => email })) end - # Change an existing collaborator. - def update_collaborator(app_name, email, access) - put("/apps/#{app_name}/collaborators/#{escape(email)}", { 'collaborator[access]' => access }) - end - # Remove a collaborator. def remove_collaborator(app_name, email) delete("/apps/#{app_name}/collaborators/#{escape(email)}") lib/heroku/client.rb @@ -116,29 +116,23 @@ EOXML @resource.should_receive(:get).and_return <<EOXML <?xml version="1.0" encoding="UTF-8"?> <collaborators type="array"> - <collaborator><email>joe@example.com</email><access>edit</access></collaborator> - <collaborator><email>jon@example.com</email><access>view</access></collaborator> + <collaborator><email>joe@example.com</email></collaborator> + <collaborator><email>jon@example.com</email></collaborator> </collaborators> EOXML @client.list_collaborators('myapp').should == [ - { :email => 'joe@example.com', :access => 'edit' }, - { :email => 'jon@example.com', :access => 'view' } + { :email => 'joe@example.com' }, + { :email => 'jon@example.com' } ] end - it "add_collaborator(app_name, email, access) -> adds collaborator to app" do + it "add_collaborator(app_name, email) -> adds collaborator to app" do @client.should_receive(:resource).with('/apps/myapp/collaborators').and_return(@resource) @resource.should_receive(:post).with({ 'collaborator[email]' => 'joe@example.com'}, anything) @client.add_collaborator('myapp', 'joe@example.com') end - it "update_collaborator(app_name, email, access) -> updates existing collaborator record" do - @client.should_receive(:resource).with('/apps/myapp/collaborators/joe%40example%2Ecom').and_return(@resource) - @resource.should_receive(:put).with({ 'collaborator[access]' => 'view'}, anything) - @client.update_collaborator('myapp', 'joe@example.com', 'view') - end - - it "remove_collaborator(app_name, email, access) -> removes collaborator from app" do + it "remove_collaborator(app_name, email) -> removes collaborator from app" do @client.should_receive(:resource).with('/apps/myapp/collaborators/joe%40example%2Ecom').and_return(@resource) @resource.should_receive(:delete) @client.remove_collaborator('myapp', 'joe@example.com') spec/client_spec.rb fd1c6192884bb7940b393a030c14673406b97276 Pedro Belo pedro@bitscribe.net http://github.com/adamwiggins/heroku-client/commit/26cb55caab83ba942ec90f0f918d255f8a5f9fe6 26cb55caab83ba942ec90f0f918d255f8a5f9fe6 2009-01-22T19:42:47-08:00 2009-01-22T19:42:47-08:00 collaborator access is now deprecated d3a5f4f34994b82338434b7ef3eea06555d4123a Pedro Belo pedro@bitscribe.net