@@ -126,7 +126,7 @@ class Heroku::Client post("/apps/#{app_name}/rake", cmd) rescue RestClient::RequestFailed => e raise(AppCrashed, e.response.body) if e.response.code.to_i == 502 - raise + raise e end # support for console sessions @@ -151,7 +151,7 @@ class Heroku::Client end rescue RestClient::RequestFailed => e raise(AppCrashed, e.response.body) if e.response.code.to_i == 502 - raise + raise e end # internal method to run console commands formatting the output lib/heroku/client.rb @@ -110,6 +110,20 @@ EOXML @client.cron_logs('myapp').should == 'cron log' end + it "rake catches 502s and shows the app crashlog" do + e = RestClient::RequestFailed.new + e.stub!(:response).and_return(mock('response', :code => '502', :body => 'the crashlog')) + @client.should_receive(:post).and_raise(e) + lambda { @client.rake('myapp', '') }.should raise_error(Heroku::Client::AppCrashed) + end + + it "rake passes other status codes (i.e., 500) as standard restclient exceptions" do + e = RestClient::RequestFailed.new + e.stub!(:response).and_return(mock('response', :code => '500', :body => 'not a crashlog')) + @client.should_receive(:post).and_raise(e) + lambda { @client.rake('myapp', '') }.should raise_error(RestClient::RequestFailed) + end + describe "collaborators" do it "list(app_name) -> list app collaborators" do @client.should_receive(:resource).with('/apps/myapp/collaborators').and_return(@resource) spec/client_spec.rb 0c8dd8e17664b8c2214ad70678bdcf3b6a3f9b78 Adam Wiggins adam@heroku.com http://github.com/adamwiggins/heroku-client/commit/5828429ac5142c5698f93a8fb77ec8f1e73e20ea 5828429ac5142c5698f93a8fb77ec8f1e73e20ea 2009-02-03T13:33:38-08:00 2009-02-03T13:33:38-08:00 spec rake catching of crashlogs 19b67c0a02040f6c00071b07aaff52e960ad3387 Adam Wiggins adam@heroku.com