adamwiggins / rest-client

like so :

module RestClient
class Request

def execute
    execute_inner
rescue Redirect => e
  @method = :get
  @payload = nil
    @url = e.url
    execute
end

end end

raw_response.rb and mixin/response.rb didn't make it into the 1.0 gem.

It's just the convention

In the current version, v1.0.4, rest-client will only attempt to inflate the server response for HTTP 2XX (success-based) responses. This behavior is unexpected and counter-to the Rails convention of providing Error details in HTTP 422 (Unprocessable Entity) - or at least non-200 - responses.

The offending code can be found here, in today's source. As you can see, deflate is only executed for successful responses, whereas unsuccessful responses just get stuffed - while still deflated - into the response, rendering the exception.response.body generally unusable.

Hello,

Given the following which returns 204/"No Content":

$ curl -v -X POST -d count=1 -u foo:bar http://localhost:8003/das/reservation [snip]

POST /das/reservation HTTP/1.1 Authorization: Basic YmlfIFJfe9pbg== User-Agent: curl/7.18.2 (i486-pc-linux-gnu) libcurl/7.18.2 OpenSSL/0.9.8g zlib/1.2.3.3 libidn/1.10 Host: localhost:8003 Accept: / Content-Length: 7 Content-Type: application/x-www-form-urlencoded

< HTTP/1.1 204 No Content
< Server: Yaws/1.84 Yet Another Web Server
< Date: Thu, 01 Oct 2009 19:02:04 GMT
< Content-Length: 112
< Content-Type: text/html
[snip]

Then why does the rest-client equivalent call return nil?:

irb(main):209:0> res = RestClient::Resource.new("http://localhost:8003",:user=>'foo',:password=>'bar')
=> #<RestClient::Resource:0xb6e5ce1c... irb(main):210:0> response_204 = res['das/reservation'].post "count=1"
=> nil

I expected a Response object with a code of 204 and a to_s of "" (i.e. empty HTTP body) to be consistent with e.g.:

irb(main):200:0> response = res['das/message_count'].get
=> "3" irb(main):201:0> response.code
=> 200

Is this behavior by design, or am I doing something wrong?

And, thank you for RestClient, I really like it.

Edward Garson

RestClient.get('http://example.com', 'Accept' => '/') results in a request with application/xml as the Accept type.

Using :accept as the key works, but not the literal string of what the header is. I believe the proper key should work too.