@@ -80,7 +80,7 @@ class Rush::Box return command unless env vars = env.map do |key, value| - "export #{key}='#{value}'" + "export #{key}=\"#{value.gsub('"', '\\"')}\"" end vars.push(command).join("\n") end lib/rush/box.rb @@ -38,7 +38,11 @@ describe Rush::Box do end it "builds a script of environment variables to prefix the bash command" do - @box.command_with_environment('cmd', { :a => 'b' }).should == "export a='b'\ncmd" + @box.command_with_environment('cmd', { :a => 'b' }).should == "export a=\"b\"\ncmd" + end + + it "escapes quotes on environment variables" do + @box.command_with_environment('cmd', { :a => 'a"b' }).should == "export a=\"a\\\"b\"\ncmd" end it "sets the environment variables from the provided hash" do spec/box_spec.rb 353e63213c8c92e056bceb2e9e190469db74f710 Pedro Belo pedro@heroku.com http://github.com/adamwiggins/rush/commit/ff4a873b965f84605bfbd6c8f5b47d4f05871c2d ff4a873b965f84605bfbd6c8f5b47d4f05871c2d 2009-11-05T11:05:57-08:00 2009-11-05T11:05:57-08:00 define env vars with double quotes, and escaping the values 2e653d21bb9a8e945927478b7f9815cfb17bd4d2 Pedro Belo pedro@heroku.com