Issues - airblade/paper_trail

airblade / paper_trail

157

Description:

Track changes to your models' data. Good for auditing or versioning.

Sort by: Priority | Votes | Last Updated

Loading…

1.

0 votes

Write RDoc documentation
0 comments Created 5 months ago by airblade

Title

Body
Document the public API.
or cancel

Document the public API.

Comments

Parsed with GitHub Flavored Markdown
3.

0 votes

Record ip of whodunit
9 comments Created 2 months ago by jalberto

Title

Body
usafull for auditing
or cancel

usafull for auditing

Comments

airblade Fri Sep 04 01:30:59 -0700 2009 | link

Currently the whodunnit field is populated by calling the current_user method on your application controller (or you can set it manually at the model/migration level).

So you could modify your current_user method to return the user's IP as well as anything else you need, though that may not be ideal for you.

Perhaps the method that PaperTrail calls on the controller to find out whodunnit should be configurable? It would default to current_user but you could then specify, say, current_user_and_ip instead. Does that sound good?

Comment
Currently the whodunnit field is populated by calling the current_user method on your application controller (or you can set it manually at the model/migration level). So you could modify your current_user method to return the user's IP as well as anything else you need, though that may not be ideal for you. Perhaps the method that PaperTrail calls on the controller to find out whodunnit should be configurable? It would default to current_user but you could then specify, say, current_user_and_ip instead. Does that sound good?
or cancel

jalberto Fri Sep 04 01:59:39 -0700 2009 | link

it would be great if its configurable, not only to get he ip, i use authlogic and the current_user method must be private.

Comment
it would be great if its configurable, not only to get he ip, i use authlogic and the current_user method must be private.
or cancel

airblade Fri Sep 04 02:21:32 -0700 2009 | link

Ok, I'll make it configurable.

By the way, PaperTrail works with authlogic's private current_user method.

Comment
Ok, I'll make it configurable. By the way, PaperTrail works with authlogic's private current_user method.
or cancel

tokumine Thu Oct 08 10:21:27 -0700 2009 | link

Another idea would be to add some hooks at certain points to the version table objects lifecycle. This would allow for easy user extension of the version table. What do you think Andy?

Comment
Another idea would be to add some hooks at certain points to the version table objects lifecycle. This would allow for easy user extension of the version table. What do you think Andy?
or cancel

airblade Fri Oct 09 01:23:18 -0700 2009 | link

Do you mean, for example, a before update hook on the version object? It sounds like an interesting idea, Simon. Did you have anything specific in mind? I don't feel I've quite grasped what you're suggesting!

Comment
Do you mean, for example, a before update hook on the version object? It sounds like an interesting idea, Simon. Did you have anything specific in mind? I don't feel I've quite grasped what you're suggesting!
or cancel

tokumine Fri Oct 09 02:01:53 -0700 2009 | link

Hi Andy, Sorry for the quick explanation! I think you've got it though, a set of before/after hooks on the version object would allow for 2 possible future scenarios:

1) Addition of user required fields to the Version table (eg. A string representation of what has changed, IP address, phase of moon etc)

2) Possibly open the door for dealing with associations.

Comment
Hi Andy, Sorry for the quick explanation! I think you've got it though, a set of before/after hooks on the version object would allow for 2 possible future scenarios: 1) Addition of user required fields to the Version table (eg. A string representation of what has changed, IP address, phase of moon etc) 2) Possibly open the door for dealing with associations.
or cancel

airblade Fri Oct 09 02:27:41 -0700 2009 | link

Thanks for the details, Simon. So would this sort of thing do?

http://gist.github.com/205881

Comment
Thanks for the details, Simon. So would this sort of thing do? http://gist.github.com/205881
or cancel

tokumine Fri Oct 09 03:54:04 -0700 2009 | link

It absolutely would! :). I guess we could also patch to pass in a proc to the has_paper_trail method to hide the opening up the Version class bit from the user? Thanks!

Comment
It absolutely would! :). I guess we could also patch to pass in a proc to the has_paper_trail method to hide the opening up the Version class bit from the user? Thanks!
or cancel

tokumine Fri Oct 09 03:54:47 -0700 2009 | link

actually, forget that. It's good to be explicit sometimes.

Comment
actually, forget that. It's good to be explicit sometimes.
or cancel

Parsed with GitHub Flavored Markdown
6.

0 votes

ActiveRecord::RecordNotSaved thrown, when calling clear on a new record
2 comments Created 28 days ago by 23inhouse

Title

Body
In a case where an association is build (not saved) and then cleared, rails calls destroy or delete. An exception is thrown - "ActiveRecord::RecordNotSaved: You cannot call create unless the parent is saved". I found adding this fixed it: def record_destroy return if new_record? ... end Maybe it could be added too record_update as well. Here is a case. class Blog < ActiveRecord::Base has_paper_trail has_many :posts end class Post < ActiveRecord::Base has_paper_trail belongs_to :blog end class BlogsController < ApplicationController def action @blog.posts.build @blog.posts.clear #now i dont want it any more end end Thanks for the great plugin, i learnt a lot by looking at the code. Thanks Ben
or cancel
In a case where an association is build (not saved) and then cleared, rails calls destroy or delete.
An exception is thrown - "ActiveRecord::RecordNotSaved: You cannot call create unless the parent is saved".

I found adding this fixed it:
def record_destroy
return if new_record? ... end
Maybe it could be added too record_update as well.

Here is a case.
class Blog < ActiveRecord::Base
has_paper_trail has_many :posts end
class Post < ActiveRecord::Base
has_paper_trail belongs_to :blog end

class BlogsController < ApplicationController
def action
```
@blog.posts.build
@blog.posts.clear #now i dont want it any more 
```
end end

Thanks for the great plugin, i learnt a lot by looking at the code.
Thanks
Ben
Comments

airblade Wed Oct 28 04:14:50 -0700 2009 | link

Hi Ben,

I can't seem to reproduce your problem. When I call @blog.posts.build and then @blog.posts.clear it works fine (Rails 2.3.4). Where is your RecordNotSaved exception being raised?

Thanks,
Andy

Comment
Hi Ben, I can't seem to reproduce your problem. When I call `@blog.posts.build` and then `@blog.posts.clear` it works fine (Rails 2.3.4). Where is your `RecordNotSaved` exception being raised? Thanks, Andy
or cancel

airblade Fri Nov 13 02:43:53 -0800 2009 | link

Any chance you could Gist your code?

Comment
Any chance you could Gist your code?
or cancel

Parsed with GitHub Flavored Markdown

Labels

Write RDoc documentation

Comments

Record ip of whodunit

Comments

ActiveRecord::RecordNotSaved thrown, when calling clear on a new record

Comments