feat: add protocol name on rpc server url (#32)

sofastack · Jan 17, 2019 · 0d7428a · 0d7428a
1 parent 1d74fd2
commit 0d7428a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/lib/server/server.js b/lib/server/server.js
@@ -114,6 +114,7 @@ class RpcServer extends Base {
       accepts: 100000,
       language: 'nodejs',
       rpcVer: '50400',
+      protocol: this.protocol.name,
     };
     return obj;
   }

diff --git a/package.json b/package.json
@@ -36,7 +36,7 @@
     "await-first": "^1.0.0",
     "byte": "^2.0.0",
     "cluster-client": "^2.1.2",
-    "debug": "^4.1.0",
+    "debug": "^4.1.1",
     "easy-table": "^1.1.1",
     "graceful": "^1.0.2",
     "is-type-of": "^1.2.1",
@@ -52,11 +52,11 @@
     "antpb": "^1.0.0",
     "autod": "^3.0.1",
     "await-event": "^2.1.0",
-    "coffee": "^5.1.0",
+    "coffee": "^5.2.1",
     "contributors": "^0.5.1",
     "dubbo-remoting": "^2.1.3",
-    "egg-bin": "^4.9.0",
-    "eslint": "^5.10.0",
+    "egg-bin": "^4.10.0",
+    "eslint": "^5.12.0",
     "eslint-config-egg": "^7.1.0",
     "mm": "^2.4.1",
     "node-zookeeper-client": "^0.2.2",

diff --git a/test/server/server.test.js b/test/server/server.test.js
@@ -44,7 +44,7 @@ describe('test/server.test.js', () => {
       logger,
       codecType: 'protobuf',
     });
-    assert(server.url.endsWith('dynamic=true&appName=test&timeout=3000&serialization=protobuf&weight=100&accepts=100000&language=nodejs&rpcVer=50400'));
+    assert(server.url.endsWith('dynamic=true&appName=test&timeout=3000&serialization=protobuf&weight=100&accepts=100000&language=nodejs&rpcVer=50400&protocol='));
     await server.close();
   });
 
@@ -56,7 +56,7 @@ describe('test/server.test.js', () => {
       codecType: 'hessian2',
     });
     assert(server.url.startsWith('dubbo://'));
-    assert(server.url.endsWith('dynamic=true&appName=test&timeout=3000&serialization=hessian2&weight=100&accepts=100000&language=nodejs&rpcVer=50400'));
+    assert(server.url.endsWith('dynamic=true&appName=test&timeout=3000&serialization=hessian2&weight=100&accepts=100000&language=nodejs&rpcVer=50400&protocol=dubbo'));
     await server.close();
   });