app/concerns/nested_params_form_builder.rb @@ -1,3 +1,5 @@ +load 'nested_params_form_builder.rb' + class ProjectsController < ApplicationController def index @projects = Project.find(:all) @@ -24,10 +26,11 @@ class ProjectsController < ApplicationController def edit @project = Project.find(params[:id]) + # add an extra new record for debugging purposes + @project.tasks.build end def update - #params[:project][:tasks] ||= [] @project = Project.find(params[:id]) if @project.update_attributes(params[:project]) flash[:notice] = "Successfully updated project." app/controllers/projects_controller.rb @@ -2,16 +2,18 @@ <%= error_messages_for :project %> -<% form_for @project do |f| -%> +<% form_for @project, :builder => NestedParamsFormBuilder do |f| -%> + <p> <%= f.label :name, "Project:" %> <%= f.text_field :name %> </p> <div id="tasks"> - <%= render :partial => 'task', :collection => @project.tasks %> + <%= render :partial => 'task', :collection => @project.tasks, :locals => { :pf => f } %> + </div> </div> <p> - <%= add_task_link "Add a task" %> + <%#= add_task_link "Add a task" %> </p> <p> <%= f.submit "Submit" %> app/views/projects/_form.html.erb @@ -1,11 +1,9 @@ <div class="task"> -<% fields_for 'project[tasks]', task, :index => '' do |f| -%> - <%= error_messages_for :task, :object => task %> - <%= f.hidden_field :id unless task.new_record? %> +<% pf.fields_for :tasks, task do |f| %> + <%#= error_messages_for :task, :object => task %> <p> <%= f.label :name, "Task:" %> <%= f.text_field :name %> <%= link_to_function "remove", "$(this).up('.task').remove()" %> </p> -<% end -%> -</div> +<% end %> \ No newline at end of file app/views/projects/_task.html.erb @@ -32,7 +32,7 @@ Rails::Initializer.run do |config| # config.plugins = [ :exception_notification, :ssl_requirement, :all ] # Add additional load paths for your own custom dirs - # config.load_paths += %W( #{RAILS_ROOT}/extras ) + config.load_paths += %W( #{RAILS_ROOT}/app/concerns ) # Force all environments to use the same logger level # (by default production uses :info, the others :debug) config/environment.rb @@ -49,6 +49,9 @@ body { .fieldWithErrors { display: inline; } +.fieldWithErrors input { + border: 1px solid red; +} #errorExplanation { width: 400px; public/stylesheets/application.css @@ -50,13 +50,18 @@ module NestedParams class_eval do define_method("#{attr}_with_nested_params=") do |value| if value.is_a? Hash - # For existing records + # For existing records and new records that are marked by an id that starts with 'new_' value.each do |id, attributes| - send(attr).detect { |x| x.id == id.to_i }.attributes = attributes + if id.starts_with? 'new_' + send(attr).build attributes + else + # Find the record for this id and assign the attributes + send(attr).detect { |x| x.id == id.to_i }.attributes = attributes + end end else if value.is_a?(Array) && value.all? { |x| x.is_a?(Hash) } - # For new records + # For an array full of new record hashes value.each do |attributes| send(attr).build attributes end vendor/plugins/has_autosave_and_nested_params/lib/nested_params.rb @@ -63,6 +63,22 @@ describe "NestedParams, on a has_many association" do @visitor.reload @visitor.artists.map(&:name).sort.should == %w{ jack joe } end + + it "should update existing records and add new ones that have an id that start with the string 'new_'" do + before = Artist.count + + @visitor.update_attributes({ + :artists => { + @artist1.id.to_s => { :name => 'joe' }, + "new_12345" => { :name => 'jill' }, + @artist2.id.to_s => { :name => 'jack' } + } + }) + @visitor.reload + + Artist.count.should.be before + 1 + @visitor.artists.map(&:name).sort.should == %w{ jack jill joe } + end end describe "NestedParams, on a has_one association" do vendor/plugins/has_autosave_and_nested_params/test/nested_params_test.rb c1cd32ba8ff8e38e426b72f36db59f3b46994e0c Eloy Duran eloy.de.enige@gmail.com http://github.com/alloy/complex-form-examples/commit/9f711f2ae148eca7b95864f1c537c99859d2b051 9f711f2ae148eca7b95864f1c537c99859d2b051 2008-08-19T16:57:03-07:00 2008-08-19T16:57:03-07:00 Toying with fields_for a has_many association and finding a way to have NestedParams build new records from those generated forms. In the case of a new record we simply generate a fictive id, but since we don't need it afterwards there's no point in keeping a counter around, thus we simply generate an id like 'new_12345' where the number is the #object_id of the record. We can then catch these new records in the NestedParams writer method and build new records. 727a599af8436805acf495eb32d459e7828dda5b Eloy Duran eloy.de.enige@gmail.com