diff --git a/CHANGELOG.md b/CHANGELOG.md index cfa21f4360..79df1ab031 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ ## Unreleased * Improve test coverage of contextual breadcrumb logic ([PR #3944](https://github.com/alphagov/govuk_publishing_components/pull/3944) and [PR #3945](https://github.com/alphagov/govuk_publishing_components/pull/3945)) +* Remove GA4 callout tracking from the govspeak component ([PR #3946](https://github.com/alphagov/govuk_publishing_components/pull/3946)) ## 37.9.1 diff --git a/app/views/govuk_publishing_components/components/_govspeak.html.erb b/app/views/govuk_publishing_components/components/_govspeak.html.erb index 913b29d08a..3cc908d8ab 100644 --- a/app/views/govuk_publishing_components/components/_govspeak.html.erb +++ b/app/views/govuk_publishing_components/components/_govspeak.html.erb @@ -10,20 +10,9 @@ classes << "disable-youtube" if disable_youtube_expansions classes << "gem-c-govspeak--inverse" if inverse - disable_ga4 ||= false - data_modules = "govspeak" - data_modules << " ga4-link-tracker" unless disable_ga4 data_attributes = { module: data_modules } - unless disable_ga4 - data_attributes.merge!({ - ga4_track_links_only: "", - ga4_limit_to_element_class: "call-to-action, info-notice, help-notice, advisory", - ga4_link: { "event_name": "navigation", "type": "callout" }.to_json, - }) - end - %> <%= tag.div(class: "gem-c-govspeak govuk-govspeak " + classes.join(" "), data: data_attributes) do %> diff --git a/app/views/govuk_publishing_components/components/_notice.html.erb b/app/views/govuk_publishing_components/components/_notice.html.erb index ea818a92f1..0f5eba2f8e 100644 --- a/app/views/govuk_publishing_components/components/_notice.html.erb +++ b/app/views/govuk_publishing_components/components/_notice.html.erb @@ -30,7 +30,6 @@ if description_govspeak govspeak_data_attributes = { content: description_govspeak, - disable_ga4: true # Keep the govspeak component GA4 tracking disabled, otherwise tracking will be duplicated when tracking is enabled on this component. } end diff --git a/app/views/govuk_publishing_components/components/docs/govspeak.yml b/app/views/govuk_publishing_components/components/docs/govspeak.yml index c79cc2aebe..4703338c7c 100644 --- a/app/views/govuk_publishing_components/components/docs/govspeak.yml +++ b/app/views/govuk_publishing_components/components/docs/govspeak.yml @@ -914,12 +914,3 @@ examples:

Deforested area. Credit: Blue Ventures-Garth Cripps

- without_ga4_tracking: - description: | - Disables GA4 tracking on the component. Tracking is enabled by default. This adds a data module and data-attributes with JSON data. See the [ga4-link-tracker documentation](https://github.com/alphagov/govuk_publishing_components/blob/main/docs/analytics-ga4/ga4-link-tracker.md) for more information. - data: - block: | -

- Hello World -

- disable_ga4: true \ No newline at end of file diff --git a/spec/components/govspeak_spec.rb b/spec/components/govspeak_spec.rb index 05d2630df9..9dc0190879 100644 --- a/spec/components/govspeak_spec.rb +++ b/spec/components/govspeak_spec.rb @@ -46,27 +46,4 @@ def component_name expect(rendered).to include("content-via-block") end - - it "adds GA4 tracking" do - render_component( - content: "

content

".html_safe, - ) - - assert_select ".gem-c-govspeak[data-module='govspeak ga4-link-tracker']" - assert_select ".gem-c-govspeak[data-ga4-track-links-only]" - assert_select ".gem-c-govspeak[data-ga4-limit-to-element-class='call-to-action, info-notice, help-notice, advisory']" - assert_select '.gem-c-govspeak[data-ga4-link="{\"event_name\":\"navigation\",\"type\":\"callout\"}"]' - end - - it "can disable GA4 tracking" do - render_component( - content: "

content

".html_safe, - disable_ga4: true, - ) - - assert_no_selector ".gem-c-govspeak[data-module='govspeak ga4-link-tracker']" - assert_no_selector ".gem-c-govspeak[data-ga4-track-links-only]" - assert_no_selector ".gem-c-govspeak[data-ga4-limit-to-element-class]" - assert_no_selector ".gem-c-govspeak[data-ga4-link]" - end end