{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":2416064,"defaultBranch":"main","name":"whitehall","ownerLogin":"alphagov","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2011-09-19T15:10:49.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/596977?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714746041.0","currentOid":""},"activityList":{"items":[{"before":"92e312e8d565c64e583b509e0feb20985fb18b08","after":"bcb221aa0151463420a89a31552edc8f50568d9c","ref":"refs/heads/implement-exit-button-for-html-attachments","pushedAt":"2024-05-03T16:43:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lauraghiorghisor-tw","name":"Laura Ghiorghisor","path":"/lauraghiorghisor-tw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91544378?s=80&v=4"},"commit":{"message":"Exit visual editor trial for HTML attachments\n\nAs part of releasing a private-beta trial for a new visual editor feature,\nwe are offering the possibility to also exit the trial for a specific document,\nincluding HTML attachments.\nThe private-beta will only offer limited content editing options, so we\nmust ensure that users with advanced markdown needs can fall back to using\nthe standard govspeak markdown editor.\n\nUsers in the trial will have a special permission, which has already been implemented.\n\nA user in the trial will always create a new document with the visual editor enabled,\nand that document wil remain marked with a DB flag ensuring that all other users with\npermissions will continue editing the document in the visual editor.\nA user in the trial may exit the visual editor, and that document will remain exited\nfor all subsequent users. A user outside the trial may also irreversibly exit a document.\nUsers with JS disabled, be it in the trial or outside the trial, should always have a\nseamless experience where they can use the default textarea. Users with JS disabled will\nalso implicitly exit the document from the trial.\n\nThe implementation is done primarily in JS, hiding or showing the visual editor and govspeak\neditor respectively. We have used a hidden field whose value we set on the server, and then\nmodify on the client via JS. The value of the hidden field gets committed on save.\nThis is all mostly already in place from the previous work on editions.\n\nChanges:\n- run a migration to add `visual_editor` field to attachments\n- allow the new field in the attachments controller\n- set the `visual_editor` field as true when building a new attachment\n- update the hidden field with the correct name and ID so that it is written to the DB\ncorrectly\n- complete feature tests with HTML specific scenarios","shortMessageHtmlLink":"Exit visual editor trial for HTML attachments"}},{"before":"8c042652d5d88d444914a7cc10b599c81ac17a6e","after":"44d44d29a1a001e5baa28347a2f616482484316e","ref":"refs/heads/implement-exit-button-for-editions","pushedAt":"2024-05-03T16:23:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lauraghiorghisor-tw","name":"Laura Ghiorghisor","path":"/lauraghiorghisor-tw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91544378?s=80&v=4"},"commit":{"message":"Exit visual editor trial for editions\n\nAs part of releasing a private-beta trial for a new visual editor feature,\nwe are offering the possibility to also exit the trial for a specific document.\nThe private-beta will only offer limited content editing options, so we\nmust ensure that users with advanced markdown needs can fall back to using\nthe standard govspeak markdown editor.\n\nUsers in the trial will have a special permission, which has already been implemented.\n\nA user in the trial will always create a new document with the visual editor enabled,\nand that document wil remain marked with a DB flag ensuring that all other users with\npermissions will continue editing the document in the visual editor.\nA user in the trial may exit the visual editor, and that document will remain exited\nfor all subsequent users. A user outside the trial may also irreversibly exit a document.\nUsers with JS disabled, be it in the trial or outside the trial, should always have a\nseamless experience where they can use the default textarea. Users with JS disabled will\nalso implicitly exit the document from the trial.\n\nThe implementation is done primarily in JS, hiding or showing the visual editor and govspeak\neditor respectively. We have used a hidden field whose value we set on the server, and then\nmodify on the client via JS. The value of the hidden field gets committed on save.\n\nChanges:\n- Add a migration to introduce a visual_editor field to editions\n- Set the field to true for all editions created by users in the visual editor experiment\n- Render it as a hidden field on the edition form defaulting to false (To handle the non-JS case)\n- Toggle the field to true when the visual editor is shown (To ensure persistence of the visual editor)\n- Introduce a button to exit the visual editor (Displayed only when the visual editor is shown)\n- Always render the Govspeak Editor (instead of a backup textarea as before)\n- JS to handle toggling of the editor and hidden field when the button is clicked\n- The hidden field name is required in the visual editor template to help facilitate extending the behaviour to other\ndocument types (produces a clear error message)\n- JS to make sure that the ID is set to either the contenteditable or govspeak textarea as appropriate\nto ensure that errors are correctly linked\n- Modify the Govspeak Editor JS to get textarea by classname instead of ID to ensure compatibility with previous change\n\nCo-authored-by: Daniel Karaj <daniel.karaj@digital.cabinet-office.gov.uk>","shortMessageHtmlLink":"Exit visual editor trial for editions"}},{"before":"5a74bf9edcee57eb89e7517379a52ef2b302c242","after":"8c042652d5d88d444914a7cc10b599c81ac17a6e","ref":"refs/heads/implement-exit-button-for-editions","pushedAt":"2024-05-03T16:19:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lauraghiorghisor-tw","name":"Laura Ghiorghisor","path":"/lauraghiorghisor-tw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91544378?s=80&v=4"},"commit":{"message":"Exit visual editor trial for editions\n\nAs part of releasing a private-beta trial for a new visual editor feature,\nwe are offering the possibility to also exit the trial for a specific document.\nThe private-beta will only offer limited content editing options, so we\nmust ensure that users with advanced markdown needs can fall back to using\nthe standard govspeak markdown editor.\n\nUsers in the trial will have a special permission, which has already been implemented.\n\nA user in the trial will always create a new document with the visual editor enabled,\nand that document wil remain marked with a DB flag ensuring that all other users with\npermissions will continue editing the document in the visual editor.\nA user in the trial may exit the visual editor, and that document will remain exited\nfor all subsequent users. A user outside the trial may also irreversibly exit a document.\nUsers with JS disabled, be it in the trial or outside the trial, should always have a\nseamless experience where they can use the default textarea. Users with JS disabled will\nalso implicitly exit the document from the trial.\n\nThe implementation is done primarily in JS, hiding or showing the visual editor and govspeak\neditor respectively. We have used a hidden field whose value we set on the server, and then\nmodify on the client via JS. The value of the hidden field gets committed on save.\n\nChanges:\n- Add a migration to introduce a visual_editor field to editions\n- Set the field to true for all editions created by users in the visual editor experiment\n- Render it as a hidden field on the edition form defaulting to false (To handle the non-JS case)\n- Toggle the field to true when the visual editor is shown (To ensure persistence of the visual editor)\n- Introduce a button to exit the visual editor (Displayed only when the visual editor is shown)\n- Always render the Govspeak Editor (instead of a backup textarea as before)\n- JS to handle toggling of the editor and hidden field when the button is clicked\n- The hidden field name is required in the visual editor template to help facilitate extending the behaviour to other\ndocument types (produces a clear error message)\n- JS to make sure that the ID is set to either the contenteditable or govspeak textarea as appropriate\nto ensure that errors are correctly linked\n- Modify the Govspeak Editor JS to get textarea by classname instead of ID to ensure compatibility with previous change\n\nCo-authored-by: Daniel Karaj <daniel.karaj@digital.cabinet-office.gov.uk>","shortMessageHtmlLink":"Exit visual editor trial for editions"}},{"before":"faf50c47d156fedcbd7672847a3b7bb497930322","after":"5a74bf9edcee57eb89e7517379a52ef2b302c242","ref":"refs/heads/implement-exit-button-for-editions","pushedAt":"2024-05-03T15:43:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lauraghiorghisor-tw","name":"Laura Ghiorghisor","path":"/lauraghiorghisor-tw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91544378?s=80&v=4"},"commit":{"message":"Exit visual editor trial for editions\n\nAs part of releasing a private-beta trial for a new visual editor feature,\nwe are offering the possibility to also exit the trial for a specific document.\nThe private-beta will only offer limited content editing options, so we\nmust ensure that users with advanced markdown needs can fall back to using\nthe standard govspeak markdown editor.\n\nUsers in the trial will have a special permission, which has already been implemented.\n\nA user in the trial will always create a new document with the visual editor enabled,\nand that document wil remain marked with a DB flag ensuring that all other users with\npermissions will continue editing the document in the visual editor.\nA user in the trial may exit the visual editor, and that document will remain exited\nfor all subsequent users. A user outside the trial may also irreversibly exit a document.\nUsers with JS disabled, be it in the trial or outside the trial, should always have a\nseamless experience where they can use the default textarea. Users with JS disabled will\nalso implicitly exit the document from the trial.\n\nThe implementation is done primarily in JS, hiding or showing the visual editor and govspeak\neditor respectively. We have used a hidden field whose value we set on the server, and then\nmodify on the client via JS. The value of the hidden field gets committed on save.\n\nChanges:\n- Add a migration to introduce a visual_editor field to editions\n- Set the field to true for all editions created by users in the visual editor experiment\n- Render it as a hidden field on the edition form defaulting to false (To handle the non-JS case)\n- Toggle the field to true when the visual editor is shown (To ensure persistence of the visual editor)\n- Introduce a button to exit the visual editor (Displayed only when the visual editor is shown)\n- Always render the Govspeak Editor (instead of a backup textarea as before)\n- JS to handle toggling of the editor and hidden field when the button is clicked\n- The hidden field name is required in the visual editor template to help facilitate extending the behaviour to other\ndocument types (produces a clear error message)\n- JS to make sure that the ID is set to either the contenteditable or govspeak textarea as appropriate\nto ensure that errors are correctly linked\n- Modify the Govspeak Editor JS to get textarea by classname instead of ID to ensure compatibility with previous change\n\nCo-authored-by: Daniel Karaj <daniel.karaj@digital.cabinet-office.gov.uk>","shortMessageHtmlLink":"Exit visual editor trial for editions"}},{"before":"91e363fc1fc0f1faa7630f37d3eb091a1b02b9a4","after":"faf50c47d156fedcbd7672847a3b7bb497930322","ref":"refs/heads/implement-exit-button-for-editions","pushedAt":"2024-05-03T15:40:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lauraghiorghisor-tw","name":"Laura Ghiorghisor","path":"/lauraghiorghisor-tw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91544378?s=80&v=4"},"commit":{"message":"Complete feature tests with missing scenarios\n\nAs part of releasing a private-beta trial for a new visual editor feature,\nwe are offering the possibility to also exit the trial for a specific document.\nThe private-beta will only offer limited content editing options, so we\nmust ensure that users with advanced markdown needs can fall back to using\nthe standard govspeak markdown editor.\n\nUsers in the trial will have a special permission, which has already been implemented.\n\nThis commit completes the feature test suite, matching the following requirements:\n- A user in the trial will always create a new document with the visual editor enabled,\nand all other users with the permission will continue editing the document in the visual editor.\n- A user in the trial may exit the visual editor, and that document will remain exited\nfor all subsequent users.\n- A user outside the trial may also irreversibly exit a document.\n- Users with JS disabled, be it in the trial or outside the trial, should always have a\nseamless experience where they can use the default textarea. Users with JS disabled will\nalso implicitly exit the document from the trial.\n\nCo-authored-by: Daniel Karaj <daniel.karaj@digital.cabinet-office.gov.uk>","shortMessageHtmlLink":"Complete feature tests with missing scenarios"}},{"before":"8fd041bece51de0f833f94b0b575bcddc5ee6ef4","after":"869215b3d72c5e99bf7543b44893cef7f016184d","ref":"refs/heads/1126-republish-document-by-slug","pushedAt":"2024-05-03T15:12:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Add feature test for republishing a document\n\nThe prime minister role needs to exist for the republishing index page\nto render properly, so I've included a specific `Given` condition\nrelated to that","shortMessageHtmlLink":"Add feature test for republishing a document"}},{"before":"a5e566c88eaa109707aaffbfa02a11d9e1848b4e","after":"92e312e8d565c64e583b509e0feb20985fb18b08","ref":"refs/heads/implement-exit-button-for-html-attachments","pushedAt":"2024-05-03T15:03:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lauraghiorghisor-tw","name":"Laura Ghiorghisor","path":"/lauraghiorghisor-tw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91544378?s=80&v=4"},"commit":{"message":"Exit visual editor trial for HTML attachments\n\nAs part of releasing a private-beta trial for a new visual editor feature,\nwe are offering the possibility to also exit the trial for a specific document,\nincluding HTML attachments.\nThe private-beta will only offer limited content editing options, so we\nmust ensure that users with advanced markdown needs can fall back to using\nthe standard govspeak markdown editor.\n\nUsers in the trial will have a special permission, which has already been implemented.\n\nA user in the trial will always create a new document with the visual editor enabled,\nand that document wil remain marked with a DB flag ensuring that all other users with\npermissions will continue editing the document in the visual editor.\nA user in the trial may exit the visual editor, and that document will remain exited\nfor all subsequent users. A user outside the trial may also irreversibly exit a document.\nUsers with JS disabled, be it in the trial or outside the trial, should always have a\nseamless experience where they can use the default textarea. Users with JS disabled will\nalso implicitly exit the document from the trial.\n\nThe implementation is done primarily in JS, hiding or showing the visual editor and govspeak\neditor respectively. We have used a hidden field whose value we set on the server, and then\nmodify on the client via JS. The value of the hidden field gets committed on save.\nThis is all mostly already in place from the previous work on editions.\n\nChanges:\n- run a migration to add `visual_editor` field to attachments\n- allow the new field in the attachments controller\n- set the `visual_editor` field as true when building a new attachment\n- update the hidden field with the correct name and ID so that it is written to the DB\ncorrectly\n- complete feature tests with HTML specific scenarios","shortMessageHtmlLink":"Exit visual editor trial for HTML attachments"}},{"before":"5d27abc6dbe7d01dbf18aed23c052827fe709523","after":"8fd041bece51de0f833f94b0b575bcddc5ee6ef4","ref":"refs/heads/1126-republish-document-by-slug","pushedAt":"2024-05-03T15:01:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"WIP shift actions and preview logic to Document model\n\nTODO:\n- shift most tests from worker to model\n- reconsider worker tests","shortMessageHtmlLink":"WIP shift actions and preview logic to Document model"}},{"before":"62c56c28ce7cf40a818cf160004b733ede5763e2","after":"a5e566c88eaa109707aaffbfa02a11d9e1848b4e","ref":"refs/heads/implement-exit-button-for-html-attachments","pushedAt":"2024-05-03T15:00:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lauraghiorghisor-tw","name":"Laura Ghiorghisor","path":"/lauraghiorghisor-tw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91544378?s=80&v=4"},"commit":{"message":"Exit visual editor trial for HTML attachments\n\nAs part of releasing a private-beta trial for a new visual editor feature,\nwe are offering the possibility to also exit the trial for a specific document,\nincluding HTML attachments.\nThe private-beta will only offer limited content editing options, so we\nmust ensure that users with advanced markdown needs can fall back to using\nthe standard govspeak markdown editor.\n\nUsers in the trial will have a special permission, which has already been implemented.\n\nA user in the trial will always create a new document with the visual editor enabled,\nand that document wil remain marked with a DB flag ensuring that all other users with\npermissions will continue editing the document in the visual editor.\nA user in the trial may exit the visual editor, and that document will remain exited\nfor all subsequent users. A user outside the trial may also irreversibly exit a document.\nUsers with JS disabled, be it in the trial or outside the trial, should always have a\nseamless experience where they can use the default textarea. Users with JS disabled will\nalso implicitly exit the document from the trial.\n\nThe implementation is done primarily in JS, hiding or showing the visual editor and govspeak\neditor respectively. We have used a hidden field whose value we set on the server, and then\nmodify on the client via JS. The value of the hidden field gets committed on save.\nThis is all mostly already in place from the previous work on editions.\n\nChanges:\n- run a migration to add `visual_editor` field to attachments\n- allow the new value in the attachments controller\n- set tha value as true when building a new attachment\n- update the hidden field with the correct name and ID so that it is written to the DB\ncorrectly\n- complete feature tests with HTML specific scenarios","shortMessageHtmlLink":"Exit visual editor trial for HTML attachments"}},{"before":"4f0ccecca6abd9f9c1063793e759579f0c150dbe","after":"5cb70ecd1ca72aa8f12e521d34d52580b20ae22b","ref":"refs/heads/refactor-republishing-api-worker","pushedAt":"2024-05-03T15:00:42.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Refactor document republishing worker\n\nThis file appears to be refactored about 3 times a year, which has\nhighlighted its complexity and need for simplifying. We hope we've taken\nsome steps in the right direction to make this easier to understand...\nApologies for the length of this commit message!\n\nHere we:\n\n1. Rename variables and methods to make it a bit clearer what they refer\n   to, to hopefully reduce the level of context required to make changes\n   to this file in future.\n\n   **A note on the term \"refresh\"**: We've used the term *refresh* for\n   actions affecting an edition to convey the fact that we're\n   updating/synchronising an edition with its associated entities e.g.\n   handling an edition's attachments as well as \"publishing\" it via the\n   Publishing API.\n\n2. Make `attr_reader`s private to make it clear that they're only\n   used in this class and can be safely refactored without needing to\n   update their usage elsewhere.\n\n3. Attempt to simplify the complex conditional statement in the\n   `perform` method through consistent language in the method names (see\n   above) and encapsulating logic in private methods relating to\n   specific edition types, as well as through the use of early returns.\n\n   We also move towards capturing most of the conditional logic\n   regarding what actions will happen in the body of the `#perform`\n   method, reducing the need to dig into the private methods to\n   understand what will happen in any given set of conditions. The only\n   outlier here is `#patch_links`.\n\n4. Attempt to introduce some structure to the file by grouping private\n   methods (using comments, sorry!) to make it clear what each group of\n   methods is responsible for, i.e. those that interact with external\n   classes vs those that encapsulate actions associated with refreshing\n   editions.\n\n5. Extend and make greater use of the `Document` model (shout out to\n   @ryanb-gds for the suggestion), rather than adding instance variables\n   and document-related logic in the worker. Upcoming work will benefit\n   from this clearer separation of concerns between worker and model,\n   allowing the worker to remain small(er than before!).\n\nCo-authored-by: George <george@dxw.com>","shortMessageHtmlLink":"Refactor document republishing worker"}},{"before":"8a60049100332cca65762bc0bc923e092ba91d01","after":"5d27abc6dbe7d01dbf18aed23c052827fe709523","ref":"refs/heads/1126-republish-document-by-slug","pushedAt":"2024-05-03T14:56:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"WIP shift actions and preview logic to Document model\n\nTODO:\n- shift most tests from worker to model\n- reconsider worker tests","shortMessageHtmlLink":"WIP shift actions and preview logic to Document model"}},{"before":"d9d28bdd9a004fe0394edb85bdc38710ed46a55e","after":"4f0ccecca6abd9f9c1063793e759579f0c150dbe","ref":"refs/heads/refactor-republishing-api-worker","pushedAt":"2024-05-03T14:49:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"Refactor document republishing worker\n\nThis file appears to be refactored about 3 times a year, which has\nhighlighted its complexity and need for simplifying. We hope we've taken\nsome steps in the right direction to make this easier to understand...\nApologies for the length of this commit message!\n\nHere we:\n\n1. Rename variables and methods to make it a bit clearer what they refer\n   to, to hopefully reduce the level of context required to make changes\n   to this file in future.\n\n   **A note on the term \"refresh\"**: We've used the term *refresh* for\n   actions affecting an edition to convey the fact that we're\n   updating/synchronising an edition with its associated entities e.g.\n   handling an edition's attachments as well as \"publishing\" it via the\n   Publishing API.\n\n2. Make `attr_reader`s private to make it clear that they're only\n   used in this class and can be safely refactored without needing to\n   update their usage elsewhere.\n\n3. Attempt to simplify the complex conditional statement in the\n   `perform` method through consistent language in the method names (see\n   above) and encapsulating logic in private methods relating to\n   specific edition types, as well as through the use of early returns.\n\n   We also move towards capturing most of the conditional logic\n   regarding what actions will happen in the body of the `#perform`\n   method, reducing the need to dig into the private methods to\n   understand what will happen in any given set of conditions. The only\n   outlier here is `#patch_links`.\n\n4. Attempt to introduce some structure to the file by grouping private\n   methods (using comments, sorry!) to make it clear what each group of\n   methods is responsible for, i.e. those that interact with external\n   classes vs those that encapsulate actions associated with refreshing\n   editions.\n\nCo-authored-by: George <george@dxw.com>","shortMessageHtmlLink":"Refactor document republishing worker"}},{"before":"6589e0036cc930ec29952203a5bfb5be0a0cf245","after":"008933aac5aa91895f8ded6cdc782a27fa87b8b1","ref":"refs/heads/translation-rework","pushedAt":"2024-05-03T14:48:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"JonathanHallam","name":"Jon Hallam","path":"/JonathanHallam","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/24547207?s=80&v=4"},"commit":{"message":"update update draft method","shortMessageHtmlLink":"update update draft method"}},{"before":"38fddfd89c85e5389acae7313959915d66383d4e","after":"91e363fc1fc0f1faa7630f37d3eb091a1b02b9a4","ref":"refs/heads/implement-exit-button-for-editions","pushedAt":"2024-05-03T14:34:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lauraghiorghisor-tw","name":"Laura Ghiorghisor","path":"/lauraghiorghisor-tw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91544378?s=80&v=4"},"commit":{"message":"Complete feature tests with missing scenarios\n\nAs part of releasing a private-beta trial for a new visual editor feature,\nwe are offering the possibility to also exit the trial for a specific document.\nThe private-beta will only offer limited content editing options, so we\nmust ensure that users with advanced markdown needs can fall back to using\nthe standard govspeak markdown editor.\n\nUsers in the trial will have a special permission, which has already been implemented.\n\nThis commit completes the feature test suite, matching the following requirements:\n- A user in the trial will always create a new document with the visual editor enabled,\nand all other users with the permission will continue editing the document in the visual editor.\n- A user in the trial may exit the visual editor, and that document will remain exited\nfor all subsequent users.\n- A user outside the trial may also irreversibly exit a document.\n- Users with JS disabled, be it in the trial or outside the trial, should always have a\nseamless experience where they can use the default textarea. Users with JS disabled will\nalso implicitly exit the document from the trial.\n\nCo-authored-by: Daniel Karaj <daniel.karaj@digital.cabinet-office.gov.uk>","shortMessageHtmlLink":"Complete feature tests with missing scenarios"}},{"before":null,"after":"62c56c28ce7cf40a818cf160004b733ede5763e2","ref":"refs/heads/implement-exit-button-for-html-attachments","pushedAt":"2024-05-03T14:20:41.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"lauraghiorghisor-tw","name":"Laura Ghiorghisor","path":"/lauraghiorghisor-tw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91544378?s=80&v=4"},"commit":{"message":"Exit visual editor trial for HTML attachments\n\nAs part of releasing a private-beta trial for a new visual editor feature,\nwe are offering the possibility to also exit the trial for a specific document,\nincluding HTML attachments.\nThe private-beta will only offer limited content editing options, so we\nmust ensure that users with advanced markdown needs can fall back to using\nthe standard govspeak markdown editor.\n\nUsers in the trial will have a special permission, which has already been implemented.\n\nA user in the trial will always create a new document with the visual editor enabled,\nand that document wil remain marked with a DB flag ensuring that all other users with\npermissions will continue editing the document in the visual editor.\nA user in the trial may exit the visual editor, and that document will remain exited\nfor all subsequent users. A user outside the trial may also irreversibly exit a document.\nUsers with JS disabled, be it in the trial or outside the trial, should always have a\nseamless experience where they can use the default textarea. Users with JS disabled will\nalso implicitly exit the document from the trial.\n\nThe implementation is done primarily in JS, hiding or showing the visual editor and govspeak\neditor respectively. We have used a hidden field whose value we set on the server, and then\nmodify on the client via JS. The value of the hidden field gets committed on save.","shortMessageHtmlLink":"Exit visual editor trial for HTML attachments"}},{"before":"60512c98da8ef1b69c17d23f23bbe994fc28aa98","after":"38fddfd89c85e5389acae7313959915d66383d4e","ref":"refs/heads/implement-exit-button-for-editions","pushedAt":"2024-05-03T13:51:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lauraghiorghisor-tw","name":"Laura Ghiorghisor","path":"/lauraghiorghisor-tw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91544378?s=80&v=4"},"commit":{"message":"Complete feature tests with missing scenarios\n\nAs part of releasing a private-beta trial for a new visual editor feature,\nwe are offering the possibility to also exit the trial for a specific document.\nThe private-beta will only offer limited content editing options, so we\nmust ensure that users with advanced markdown needs can fall back to using\nthe standard govspeak markdown editor.\n\nUsers in the trial will have a special permission, which has already been implemented.\n\nThis commit completes the feature test suite, matching the following requirements:\n- A user in the trial will always create a new document with the visual editor enabled,\nand all other users with the permission will continue editing the document in the visual editor.\n- A user in the trial may exit the visual editor, and that document will remain exited\nfor all subsequent users.\n- A user outside the trial may also irreversibly exit a document.\n- Users with JS disabled, be it in the trial or outside the trial, should always have a\nseamless experience where they can use the default textarea. Users with JS disabled will\nalso implicitly exit the document from the trial.\n\nCo-authored-by: Daniel Karaj <daniel.karaj@digital.cabinet-office.gov.uk>","shortMessageHtmlLink":"Complete feature tests with missing scenarios"}},{"before":"7d9ef1a21111d35c0c6078cf9aa3a359069b7a11","after":"60512c98da8ef1b69c17d23f23bbe994fc28aa98","ref":"refs/heads/implement-exit-button-for-editions","pushedAt":"2024-05-03T13:30:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lauraghiorghisor-tw","name":"Laura Ghiorghisor","path":"/lauraghiorghisor-tw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91544378?s=80&v=4"},"commit":{"message":"Complete feature tests with missing scenarios\n\nAs part of releasing a private-beta trial for a new visual editor feature,\nwe are offering the possibility to also exit the trial for a specific document.\nThe private-beta will only offer limited content editing options, so we\nmust ensure that users with advanced markdown needs can fall back to using\nthe standard govspeak markdown editor.\n\nUsers in the trial will have a special permission, which has already been implemented.\n\nThis commit completes the feature test suite, matching the following requirements:\n- A user in the trial will always create a new document with the visual editor enabled,\nand all other users with the permission will continue editing the document in the visual editor.\n- A user in the trial may exit the visual editor, and that document will remain exited\nfor all subsequent users.\n- A user outside the trial may also irreversibly exit a document.\n- Users with JS disabled, be it in the trial or outside the trial, should always have a\nseamless experience where they can use the default textarea. Users with JS disabled will\nalso implicitly exit the document from the trial.\n\nCo-authored-by: Daniel Karaj <daniel.karaj@digital.cabinet-office.gov.uk>","shortMessageHtmlLink":"Complete feature tests with missing scenarios"}},{"before":"f0a54ea160a170f594245185322f6e6f482c0555","after":"7d9ef1a21111d35c0c6078cf9aa3a359069b7a11","ref":"refs/heads/implement-exit-button-for-editions","pushedAt":"2024-05-03T12:45:05.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lauraghiorghisor-tw","name":"Laura Ghiorghisor","path":"/lauraghiorghisor-tw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91544378?s=80&v=4"},"commit":{"message":"Complete feature tests with missing scenarios","shortMessageHtmlLink":"Complete feature tests with missing scenarios"}},{"before":"e86dd6ae65eee0c72dca1b7b88ee74b4e2d9b1d4","after":"f0a54ea160a170f594245185322f6e6f482c0555","ref":"refs/heads/implement-exit-button-for-editions","pushedAt":"2024-05-03T12:12:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lauraghiorghisor-tw","name":"Laura Ghiorghisor","path":"/lauraghiorghisor-tw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91544378?s=80&v=4"},"commit":{"message":"Complete feature tests with missing scenarios","shortMessageHtmlLink":"Complete feature tests with missing scenarios"}},{"before":"bd195b4fd9653ebc56ac0b5b165478936a67facf","after":"8a60049100332cca65762bc0bc923e092ba91d01","ref":"refs/heads/1126-republish-document-by-slug","pushedAt":"2024-05-03T11:39:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"WIP shift actions and preview logic to Document model\n\nTODO:\n- shift most tests from worker to model\n- reconsider worker tests","shortMessageHtmlLink":"WIP shift actions and preview logic to Document model"}},{"before":"697343f6af092e7cd6fa64b7c3f609ae00765b59","after":"bd195b4fd9653ebc56ac0b5b165478936a67facf","ref":"refs/heads/1126-republish-document-by-slug","pushedAt":"2024-05-03T11:33:28.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"WIP shift actions and preview logic to Document model\n\nTODO:\n- shift most tests from worker to model\n- reconsider worker tests","shortMessageHtmlLink":"WIP shift actions and preview logic to Document model"}},{"before":"ac3bd0684213ca8405989b7fbc0c7135d1075dbb","after":"e86dd6ae65eee0c72dca1b7b88ee74b4e2d9b1d4","ref":"refs/heads/implement-exit-button-for-editions","pushedAt":"2024-05-03T11:26:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"lauraghiorghisor-tw","name":"Laura Ghiorghisor","path":"/lauraghiorghisor-tw","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/91544378?s=80&v=4"},"commit":{"message":"Complete feature tests with missing scenarios","shortMessageHtmlLink":"Complete feature tests with missing scenarios"}},{"before":"dacf62ab09555ec803a80efd69b770ed3727ffa9","after":"ac3bd0684213ca8405989b7fbc0c7135d1075dbb","ref":"refs/heads/implement-exit-button-for-editions","pushedAt":"2024-05-03T11:12:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"dnkrj","name":"Daniel Karaj","path":"/dnkrj","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9594455?s=80&v=4"},"commit":{"message":"wip","shortMessageHtmlLink":"wip"}},{"before":"dd68d35b29d3f04fa9e5a11f1410d41539c778e1","after":null,"ref":"refs/heads/fix-contact-org-page","pushedAt":"2024-05-03T10:49:43.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ChrisBAshton","name":"Chris Ashton","path":"/ChrisBAshton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5111927?s=80&v=4"}},{"before":"c1f99a6cf41eee840c8c12c09540a17e55392615","after":"b3d036b88d8328ee5aeeb69c75d35276722be4d2","ref":"refs/heads/main","pushedAt":"2024-05-03T10:49:42.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"ChrisBAshton","name":"Chris Ashton","path":"/ChrisBAshton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5111927?s=80&v=4"},"commit":{"message":"Merge pull request #9023 from alphagov/fix-contact-org-page\n\nRepublish organisation page when contact is updated","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2277374183\" data-permission-text=\"Title is private\" data-url=\"https://github.com/alphagov/whitehall/issues/9023\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/alphagov/whitehall/pull/9023/hovercard\" href=\"https://github.com/alphagov/whitehall/pull/9023\">#9023</a> from alphagov/fix-contact-org-page"}},{"before":"740779e5c53a66578dc9b4ea1ae61445fde7988c","after":"dacf62ab09555ec803a80efd69b770ed3727ffa9","ref":"refs/heads/implement-exit-button-for-editions","pushedAt":"2024-05-03T10:44:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"dnkrj","name":"Daniel Karaj","path":"/dnkrj","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9594455?s=80&v=4"},"commit":{"message":"wip","shortMessageHtmlLink":"wip"}},{"before":null,"after":"dd68d35b29d3f04fa9e5a11f1410d41539c778e1","ref":"refs/heads/fix-contact-org-page","pushedAt":"2024-05-03T10:21:00.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ChrisBAshton","name":"Chris Ashton","path":"/ChrisBAshton","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5111927?s=80&v=4"},"commit":{"message":"Republish organisation page when contact is updated\n\nA bug was reported in Zendesk recently:\nhttps://govuk.zendesk.com/agent/tickets/5818031\n\nSomeone set a contact to appear on the org homepage, but they\nnever appeared. Running the\n`publishing_api:republish:organisation_by_slug` rake task fixes\nthe issue, so clearly the organisation is not being republished\nwhen it should be.\n\nWe already have callbacks for updating the organisation when a\ncontact is created or destroyed, but not when a contact is\nupdated. I've been able to consistently reproduce the bug whereby\nediting contact info does not get reflected on the org page.\nAdding this callback should fix that bug, and should prevent\nfurther issues of this nature.","shortMessageHtmlLink":"Republish organisation page when contact is updated"}},{"before":"f538e183c1608fb1d05e9270370fcd7654c8be2b","after":"697343f6af092e7cd6fa64b7c3f609ae00765b59","ref":"refs/heads/1126-republish-document-by-slug","pushedAt":"2024-05-03T10:13:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"WIP shift actions and preview logic to Document model\n\nTODO:\n- shift most tests from worker to model\n- reconsider worker tests","shortMessageHtmlLink":"WIP shift actions and preview logic to Document model"}},{"before":"1da146664854aa6e712f7fa2dc8968ef61d79d5e","after":"f538e183c1608fb1d05e9270370fcd7654c8be2b","ref":"refs/heads/1126-republish-document-by-slug","pushedAt":"2024-05-03T10:06:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"yndajas","name":"Ynda Jas","path":"/yndajas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/40244233?s=80&v=4"},"commit":{"message":"WIP shift actions and preview logic to Document model\n\nTODO:\n- shift most tests from worker to model\n- reconsider worker tests","shortMessageHtmlLink":"WIP shift actions and preview logic to Document model"}},{"before":null,"after":"419479bf2788b96dca3d3144dd13b57e00652b49","ref":"refs/heads/dependabot/bundler/launchy-3.0.1","pushedAt":"2024-05-03T09:52:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump launchy from 3.0.0 to 3.0.1\n\nBumps [launchy](https://github.com/copiousfreetime/launchy) from 3.0.0 to 3.0.1.\n- [Changelog](https://github.com/copiousfreetime/launchy/blob/main/HISTORY.md)\n- [Commits](https://github.com/copiousfreetime/launchy/compare/v3.0.0...v3.0.1)\n\n---\nupdated-dependencies:\n- dependency-name: launchy\n  dependency-type: direct:development\n  update-type: version-update:semver-patch\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"Bump launchy from 3.0.0 to 3.0.1"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQPIriAA","startCursor":null,"endCursor":null}},"title":"Activity · alphagov/whitehall"}