From a34eab4cd92870b9a895939fe594426b38d48100 Mon Sep 17 00:00:00 2001 From: pivotal Date: Wed, 18 Jun 2008 13:50:47 -0700 Subject: [PATCH] Refactoring verify_recaptcha_test --- test/verify_recaptcha_test.rb | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/test/verify_recaptcha_test.rb b/test/verify_recaptcha_test.rb index 491c7596..c0006d40 100644 --- a/test/verify_recaptcha_test.rb +++ b/test/verify_recaptcha_test.rb @@ -29,8 +29,7 @@ def test_should_raise_exception_without_private_key end def test_should_return_false_when_key_is_invalid - response = response_with_body("false\ninvalid-site-private-key") - Net::HTTP.expects(:post_form).with(@expected_uri, @expected_post_data).returns(response) + expect_http_post(response_with_body("false\ninvalid-site-private-key")) assert !@controller.verify_recaptcha assert_equal "invalid-site-private-key", @controller.session[:recaptcha_error] @@ -38,15 +37,14 @@ def test_should_return_false_when_key_is_invalid def test_returns_true_on_success @controller.session[:recaptcha_error] = "previous error that should be cleared" - Net::HTTP.expects(:post_form).with(@expected_uri, @expected_post_data).returns(response_with_body("true\n")) + expect_http_post(response_with_body("true\n")) assert @controller.verify_recaptcha assert_nil @controller.session[:recaptcha_error] end def test_errors_should_be_added_to_model - response = response_with_body("false\nbad-news") - Net::HTTP.expects(:post_form).with(@expected_uri, @expected_post_data).returns(response) + expect_http_post(response_with_body("false\nbad-news")) errors = mock errors.expects(:add_to_base).with("Captcha response is incorrect, please try again.") @@ -70,6 +68,10 @@ def initialize end end + def expect_http_post(response) + Net::HTTP.expects(:post_form).with(@expected_uri, @expected_post_data).returns(response) + end + def response_with_body(body) stub(:body => body) end