fix: flushDirtyRows will not throw an error when no dirty rows

angular-ui · Jul 30, 2015 · d46d04c · d46d04c
1 parent d9c50cf
commit d46d04c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/features/row-edit/js/gridRowEdit.js b/src/features/row-edit/js/gridRowEdit.js
@@ -393,7 +393,7 @@
          */
         flushDirtyRows: function(grid){
           var promises = [];
-          grid.rowEdit.dirtyRows.forEach( function( gridRow ){
+          grid.api.rowEdit.getDirtyRows().forEach( function( gridRow ){
             service.saveRow( grid, gridRow )();
             promises.push( gridRow.rowEditSavePromise );
           });

diff --git a/src/features/row-edit/test/uiGridRowEditService.spec.js b/src/features/row-edit/test/uiGridRowEditService.spec.js
@@ -530,6 +530,12 @@ describe('ui.grid.edit uiGridRowEditService', function () {
       expect( success ).toEqual(false);
       expect( failure ).toEqual(true);
     });
+
+    it( 'no dirty rows, no error is thrown', function() {
+      expect(function() {
+        uiGridRowEditService.flushDirtyRows( grid );
+      }).not.toThrow();
+    });
   });