Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL: scrolling janky/not working on OSX trackpad #1689

Open
PaulL1 opened this issue Oct 3, 2014 · 8 comments
Open

RTL: scrolling janky/not working on OSX trackpad #1689

PaulL1 opened this issue Oct 3, 2014 · 8 comments

Comments

@PaulL1
Copy link
Contributor

PaulL1 commented Oct 3, 2014

Not clear if it's a Mac specific issue, or more general. The scrolling with a trackpad on the RTL tutorial is reversed from all other grids.

@PaulL1 PaulL1 added this to the Future milestone Oct 3, 2014
@PaulL1 PaulL1 modified the milestones: 3.0, Future Oct 15, 2014
@c0bra c0bra assigned c0bra and PaulL1 and unassigned c0bra Nov 13, 2014
@c0bra
Copy link
Contributor

c0bra commented Nov 13, 2014

There's a normalizeScrollLeft() method in gridUtil. @PaulL1 since you have a Mac handy could you please paste the returned values for that tutorial when the tutorial is at the left, right, and middle horizontal scroll positions, as well as manually pulling the scrollLeft property from .ui-grid-viewport? Thanks! You get all the Mac fun :)

@PaulL1
Copy link
Contributor Author

PaulL1 commented Nov 14, 2014

OK:

  • when scrolled to the far right it returns 0, the viewport shows 2500
  • when in about the middle it returns 1061, the viewport shows 1439
  • when scrolled to the far left it returns 2500, the viewport shows 0

In each case it correctly identifies that we're Chrome and RTL.

@PaulL1 PaulL1 assigned c0bra and unassigned PaulL1 Nov 14, 2014
@c0bra
Copy link
Contributor

c0bra commented Dec 15, 2014

These are the same values I get in Chrome on Windows.

@PaulL1 It's trackpad-only, right? Would it be possible to get a gist of a mousewheel event by setting an Event Listener Breakpoint in the debugger? Let me know which direction the event is from (i.e. swiping my fingers left) and I can compare it with an event from a different OS.

@PaulL1
Copy link
Contributor Author

PaulL1 commented Dec 28, 2014

Looking for old things to close. This one I appear to have misplaced, so doing it now.

I'm on OSX Yosemite 10.10.1, and Chrome 39.0.2171.95 (64-bit). I have my trackpad set the normal Mac way - which means it drags sort of like an iPad. When I move my fingers right to left on the trackpad, the screen scrolls to the right (i.e. the semantics are that you are dragging the viewport with your fingers). I think this is reversed from the standard Windows setup, so that will make describing this harder.

Firstly, the behaviour I get on http://ui-grid.info/docs/#/tutorial/191_horizontal_scrolling:

  1. I scroll to the right (move my fingers from right to left on the trackpad).
  2. With a breakpoint in normalizeWheelEvent, the event is a wheelEvent
  3. DeltaX: 1, DeltaY: -0, OffsetX: 51, OffsetY: 5, WheelDelta: -3, WheelDeltaX: -3

Secondly, same thing on http://ui-grid.info/docs/#/tutorial/191_horizontal_scrolling

  1. I move my fingers from right to left on the trackpad, I'd expect to similarly see the grid scroll right (the viewport move from right to left)
  2. in normalizeWheelEvent, the event is a wheelEvent (FYI, Chrome misbehaving, it isn't hitting the breakpoint in normalizeWheelEvent, but lets me step into it. Weird, but I've seen behaviour like that before so ignoring it)
  3. DeltaX: 1, DeltaY: -0, OffsetX: 160, OffsetY: 9, WheelDelta: -3, WheelDeltaX: -3

However, the grid seems to scroll left - which I think is probably because of something in RTL reversing the scroll order.

@c0bra c0bra closed this as completed in fbb3631 Mar 11, 2015
@c0bra c0bra reopened this Mar 11, 2015
@PaulL1
Copy link
Contributor Author

PaulL1 commented Mar 11, 2015

Process for getting a wheelEvent (documented in case I need to do it again).

  delete event.originalEvent.path; delete event.originalEvent.currentTarget; delete event.originalEvent.target; delete event.originalEvent.srcElement; delete event.originalEvent.toElement; delete event.preventDefault; delete event.originalEvent.isDefaultPrevented; delete event.originalEvent.view;
  JSON.stringify(event);

Then copy and paste the result into http://json.parser.online.fr/.
Then copy and paste the formatted version into https://gist.github.com/
Then post.

@PaulL1
Copy link
Contributor Author

PaulL1 commented Mar 28, 2015

I think this is fixed - at least it is on the tutorial site. However, leaving open for a wee while as I know that @swalters changes to scrolling may impact it.

@PaulL1
Copy link
Contributor Author

PaulL1 commented Apr 12, 2015

This is busted for me as of today. Setting back to a defect.

@PaulL1 PaulL1 changed the title RTL: horizontal scrolling reversed on OSX/Chrome RTL: scrolling janky/not working on OSX trackpad Apr 12, 2015
@c0bra c0bra modified the milestones: 3.1, 3.0 May 18, 2015
@c0bra
Copy link
Contributor

c0bra commented May 18, 2015

Moving to 3.1 as this has been such an unsolvable problem that we don't want it to block a 3.0 release.

mportuga added a commit that referenced this issue Dec 8, 2016
Adding support for providing a custom scroller and a new scroller that makes touch devices scroll without a lag between various pieces of the grid.

#1689, #3719, #5833
@mportuga mportuga added this to High priority in Bug Triage Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bug Triage
  
High priority
Development

No branches or pull requests

3 participants