Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headerRowHeight no longer working #2822

Closed
cookednoodles opened this issue Feb 20, 2015 · 2 comments
Closed

headerRowHeight no longer working #2822

cookednoodles opened this issue Feb 20, 2015 · 2 comments
Assignees
@c0bra
Labels
type: bug
Milestone
3.0

Comments

@cookednoodles
Copy link
Contributor

In the recent builds, headerRowHeight is no longer working
plunker : http://plnkr.co/edit/MhqMYOaf76o7G2Zo7hFW?p=preview
@c0bra c0bra self-assigned this Feb 20, 2015
@c0bra
Copy link
Contributor

c0bra commented Feb 20, 2015

Must be due to my latest alteration for dynamic header heights.

@c0bra c0bra added this to the 3.0 milestone Feb 20, 2015
@c0bra
Copy link
Contributor

c0bra commented Feb 20, 2015

I can't see that this worked in any of the RCs, even going back to rc.12. The calculation needs to be fixed so that it can calculate the height of whatever ends up in the ui-grid-header directive. We may need to remove replace: true so we have a reference point.

Once that's done you can just set the height with CSS.

@c0bra c0bra closed this as completed in d841b92 Feb 23, 2015
@c0bra c0bra mentioned this issue Jun 2, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@c0bra c0bra

Labels
type: bug
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@c0bra @cookednoodles