Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower does not fetch less files #3368

Closed
salarmehr opened this issue Apr 27, 2015 · 6 comments
Closed

Bower does not fetch less files #3368

salarmehr opened this issue Apr 27, 2015 · 6 comments
Assignees
Milestone

Comments

@salarmehr
Copy link

Getting the package using bower, does not download the less files. What is the correct way to use bower and have less files?

@c0bra
Copy link
Contributor

c0bra commented Apr 27, 2015

Currently the bower repo doesn't include less files. There have been requests from different people to either include them or leave them out.

If anyone has comments/suggestions for making everyone happy please add a comment here.

@PaulL1
Copy link
Contributor

PaulL1 commented May 15, 2015

@c0bra, I don't see what harm could be caused by including the less files in the bower repository. People who don't want to use them don't have to. It seems that where people want to override styles then having the less files gives them that ability, if we distribute only the css then it's harder.

@salarmehr
Copy link
Author

Actually, less files are necessary for minification. ui-grid uses font-face, We need a less variable to set the vendor folder path, similar to what I do for font-awesome. Currently I have to modify ui-grid css files manually which will undo on the next bower update.

Also, including css files in a less file does not embed it, only links to it.

@salarmehr
Copy link
Author

@c0bra Did you make any decision regarding the issue?

@JLLeitschuh
Copy link
Contributor

Re opening:

@JLLeitschuh
Copy link
Contributor

Unfortunately, this is still slightly broken.
There is currently no way to setup your npm directory so that bootstrap is in the right location so that the includes can be resolved.

@JLLeitschuh JLLeitschuh assigned JLLeitschuh and unassigned c0bra Aug 13, 2015
@JLLeitschuh JLLeitschuh added this to the 3.0.* milestone Aug 13, 2015
JLLeitschuh added a commit that referenced this issue Aug 15, 2015
Makes the bootstrap directory import use a variable so that it can be
overwitten.

Closes #3368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants