Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect with shift in IE 11 #3392

Open
rangoy opened this issue Apr 30, 2015 · 5 comments
Open

Multiselect with shift in IE 11 #3392

rangoy opened this issue Apr 30, 2015 · 5 comments

Comments

@rangoy
Copy link
Contributor

rangoy commented Apr 30, 2015

Using mulitselect with shift on the grid in IE gives also select other random dom elements, which gives a buggy feeling.

Tested on http://ui-grid.info/docs/#/tutorial/210_selection and ui-grid 3.0-RC21 in our project.

Tested with IE11, version number 11.0.9600.17728, update 11.0.18.

Steps to reproduce:

  1. Open http://ui-grid.info/docs/#/tutorial/210_selection in IE11.
  2. Select one element in the list by clicking the left checkbox
  3. Press shift, and click on an other element in the list

This happened when I used shift to select multiple elements;
image

I'am trying to apply the following workarround, and it seems to work. Hopefully it won't break anything else

<div ui-grid="gridOptions" ui-grid-selection ui-grid-resize-columns ng-mousedown="$event.shiftKey && $event.preventDefault()">
});
@PaulL1
Copy link
Contributor

PaulL1 commented May 16, 2015

Unfortunately I don't have IE11 to try to recreate. The behaviour we get on Chrome is that it selects all the rows in between, presumably that's also what you're expecting?

@swalters, @c0bra, do either of you have IE11 to take a look at this?

@rangoy
Copy link
Contributor Author

rangoy commented May 18, 2015

@PaulL1; yes. In chrome it works perfectly.

In IE, the correct elements are selected too. But in addition other text on the page get's selected. Clicking on an emptry space on the page clears this selection and retains the select items in the list.

To sum up: this issue concerns as far as I know just IE, not firefox nor chrome. it's just an visual bug and the functionality works as expected

@c0bra
Copy link
Contributor

c0bra commented May 18, 2015

Confirmed it's an issue in IE11.

It probably has something to do with the click handler not preventing default or something like that.

@c0bra c0bra added this to the 3.0 milestone May 18, 2015
@c0bra c0bra self-assigned this May 18, 2015
@c0bra c0bra closed this as completed in a1bbc0c May 26, 2015
@rangoy
Copy link
Contributor Author

rangoy commented Jun 4, 2015

Hi,

I see this fiexed the issue when selecting in the left checkbox column in the example. But if you enable full row selection, the issue still remains.

Steps to reproduce in doc example for version v3.0.0-rc.21-2ad8f7f:

  1. Press "Toggle full selection
  2. Click on eg. a name in the list
  3. Press shift and click a name on another row.

@arunkotagiri
Copy link

anyone has a fix for this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants