db/migrate/20081224020432_remove_openid_authority_from_comment.rb @@ -49,7 +49,6 @@ class CommentsController < ApplicationController @comment.author_url = @comment.author @comment.author = (registration["fullname"] || registration["nickname"] || @comment.author_url).to_s @comment.author_email = registration["email"].to_s - @comment.author_openid_authority = result.server_url @comment.openid_error = "" end app/controllers/comments_controller.rb @@ -38,7 +38,7 @@ module UrlHelper if comment.author_url.blank? h(comment.author) else - link_to(h(comment.author), h(comment.author_url), :title => h("Authenticated by #{comment.author_openid_authority}"), :class => 'openid') + link_to(h(comment.author), h(comment.author_url), :class => 'openid') end end app/helpers/url_helper.rb @@ -23,7 +23,6 @@ class Comment < ActiveRecord::Base end def blank_openid_fields - self.author_openid_authority = "" self.author_url = "" self.author_email = "" end app/models/comment.rb @@ -16,7 +16,6 @@ ActiveRecord::Schema.define(:version => 9) do t.string "author", :null => false t.string "author_url", :null => false t.string "author_email", :null => false - t.string "author_openid_authority", :null => false t.text "body", :null => false t.text "body_html", :null => false t.datetime "created_at" db/schema.rb @@ -184,10 +184,6 @@ describe CommentsController, 'handling commenting' do it_should_behave_like("creating new comment") - it 'records OpenID authority ' do - assigns(:comment).author_openid_authority.should == 'http://example.com' - end - it 'records OpenID identity url' do assigns(:comment).author_url.should == 'http://enkiblog.com' end @@ -212,7 +208,6 @@ describe CommentsController, 'handling commenting' do # Attributes you are not allowed to set :author_url => 'http://www.enkiblog.com', :author_email => 'donalias@enkiblog.com', - :author_openid_authority => 'http://enkiblog.com/openid_server', :created_at => @created_at = 1.year.ago, :updated_at => @updated_at = 1.year.ago, } @@ -235,10 +230,6 @@ describe CommentsController, 'handling commenting' do assigns(:comment).author_email.should be_blank end - it "forbids setting of author_openid_authority" do - assigns(:comment).author_openid_authority.should be_blank - end - it "forbids setting of created_at" do assigns(:comment).created_at.should_not == @created_at end spec/controllers/comments_controller_spec.rb @@ -93,7 +93,6 @@ describe Comment, '#blank_openid_fields_if_unused' do @comment.blank_openid_fields end - it('blanks out author_openid_authority') { @comment.author_openid_authority.should == '' } it('blanks out author_url') { @comment.author_url.should == '' } it('blanks out author_email') { @comment.author_email.should == '' } end spec/models/comment_spec.rb @@ -9,7 +9,6 @@ describe "/admin/comments/show.html.erb" do assigns[:comment] = Comment.new( :author => 'Don Alias', :author_url => 'http://enkiblog.com', - :author_openid_authority => 'http://example.com', :author_email => 'donalias@enkiblog.com', :body => 'Hello I am a post', :created_at => Time.now spec/views/admin/comments/show.html.erb_spec.rb 8a12ae5135b34bc31172078fc876364cefcfc522 Xavier Shay xavier@rhnh.net http://github.com/antonjenkins/enki/commit/f06cb00d168073afcda9ae4fc6a56ed3b547712b f06cb00d168073afcda9ae4fc6a56ed3b547712b 2008-12-23T18:10:25-08:00 2008-12-23T18:10:25-08:00 Remove OpenID authority field from comments This is not supported by the openid plugin, and is kinda useless info anyway 247cfd15335bc3be6d61c2ec0d008309391ee724 Xavier Shay xavier@rhnh.net