Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go to 1.17 #3189

Merged

Conversation

antoninbas
Copy link
Contributor

We update the Go version for the Antrea v1.2 release train, which is
still maintained.
See #3181

This is a combination of several commits from the Antrea main branch:

Signed-off-by: Antonin Bas abas@vmware.com

We update the Go version for the Antrea v1.2 release train, which is
still maintained.
See antrea-io#3181

This is a combination of several commits from the Antrea main branch:
* 7f448b0
* 2626ad0
* d44b838
* ecef57f
* 7211166

Signed-off-by: Antonin Bas <abas@vmware.com>
@antoninbas antoninbas requested a review from tnqn January 11, 2022 18:44
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor Author

/test-all

@antoninbas
Copy link
Contributor Author

@tnqn @XinShuYang I assume that the Jenkins jobs cannot pass for this because the release-1.2 branch does not use the new CI setup?

@tnqn
Copy link
Member

tnqn commented Jan 27, 2022

I can see some builds in new CI ran for cherry-pick PRs, there should be no difference.
/test-all

@XinShuYang
Copy link
Contributor

I triggered some jobs again based on old version release and found it failed because we have code change in test-vmc.sh to modify yaml file for new lab jenkins cluster. Since VMC is still not recovered, Should we also backport CI setup patch to 1.2-1.4 release? @tnqn

@tnqn
Copy link
Member

tnqn commented Jan 27, 2022

@XinShuYang Yes, we need to validate PRs on these releases, please backport it, thanks.

@tnqn
Copy link
Member

tnqn commented Jan 27, 2022

/test-all

@tnqn
Copy link
Member

tnqn commented Jan 27, 2022

/skip-e2e failed on TestFlowAggregator
/test-integration

@tnqn tnqn merged commit 5ce54f3 into antrea-io:release-1.2 Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants