Implement garbage collector for IP Pools #3672

annakhm · 2022-04-20T21:27:58Z

A periodic task would go over all IP Pools and clean up
all allocations and reservations for which owner no longer
exists in k8s.

Signed-off-by: Anna Khmelnitsky akhmelnitsky@vmware.com

codecov-commenter · 2022-04-20T22:55:46Z

Codecov Report

Merging #3672 (df80c2d) into main (ba8210c) will increase coverage by 1.27%.
The diff coverage is 84.44%.

@@            Coverage Diff             @@
##             main    #3672      +/-   ##
==========================================
+ Coverage   63.56%   64.84%   +1.27%     
==========================================
  Files         278      278              
  Lines       39360    39547     +187     
==========================================
+ Hits        25020    25643     +623     
+ Misses      12420    11917     -503     
- Partials     1920     1987      +67

Flag	Coverage Δ
e2e-tests	`50.10% <22.22%> (?)`
kind-e2e-tests	`52.19% <22.22%> (+1.39%)`	⬆️
unit-tests	`43.84% <84.44%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/controller/ipam/antrea_ipam_controller.go	`76.52% <84.44%> (-2.56%)`	⬇️
pkg/agent/nodeportlocal/k8s/annotations.go	`84.44% <0.00%> (-15.56%)`	⬇️
pkg/apiserver/handlers/endpoint/handler.go	`56.52% <0.00%> (-13.05%)`	⬇️
pkg/agent/flowexporter/connections/connections.go	`75.75% <0.00%> (-2.27%)`	⬇️
pkg/agent/nodeportlocal/k8s/npl_controller.go	`61.21% <0.00%> (-1.87%)`	⬇️
pkg/ovs/openflow/ofctrl_builder.go	`58.20% <0.00%> (-1.48%)`	⬇️
pkg/agent/openflow/pipeline.go	`74.16% <0.00%> (-1.21%)`	⬇️
pkg/util/k8s/node.go	`87.62% <0.00%> (-1.04%)`	⬇️
pkg/agent/openflow/network_policy.go	`84.88% <0.00%> (-1.03%)`	⬇️
... and 53 more

annakhm · 2022-04-21T01:15:34Z

/test-e2e

annakhm · 2022-04-21T23:38:41Z

/test-flexible-ipam-e2e

annakhm · 2022-04-25T18:16:44Z

/test-e2e

annakhm · 2022-04-25T18:18:08Z

I think garbage collector interval should be increased (1 min in this PR), would appreciate feedback.

jianjuns

LGTM.

I think we can do every 10 mins.

gran-vmv · 2022-04-26T02:06:58Z

LGTM.

I think we can do every 10 mins.

Agree with Jianjun. 10min is OK.

annakhm · 2022-04-26T04:39:30Z

LGTM.
I think we can do every 10 mins.

Agree with Jianjun. 10min is OK.

Thank you, increased to 10min.

pkg/controller/ipam/antrea_ipam_controller.go

pkg/controller/ipam/antrea_ipam_controller_test.go

pkg/controller/ipam/antrea_ipam_controller.go

tnqn

LGTM

tnqn · 2022-04-28T17:16:04Z

/test-all
/test-flexible-ipam-e2e

jianjuns · 2022-04-28T18:54:53Z

@annakhm there is a unit test failure.

annakhm · 2022-04-29T01:48:48Z

@annakhm there is a unit test failure.

Thanks @jianjuns, hopefully fixed now

pkg/controller/ipam/antrea_ipam_controller.go

tnqn · 2022-04-29T08:26:37Z

--- FAIL: TestReleaseStaleAddresses (0.20s)
    antrea_ipam_controller_test.go:261: IP Pool status: [{10.2.2.12 Reserved {<nil> 0xc0005a0d80}} {20.2.2.13 Reserved {<nil> 0xc0005a0db0}} {20.2.2.14 Reserved {<nil> 0xc0005a0de0}} {20.2.2.15 Allocated {0xc00030f240 0xc0005a0e10}}]
    testing.go:1152: race detected during execution of test

annakhm · 2022-04-29T21:17:09Z

/test-all

annakhm · 2022-04-29T23:49:50Z

/test-e2e

annakhm · 2022-05-02T19:01:18Z

/test-all

A periodic task would go over all IP Pools and clean up all allocations and reservations for which owner no longer exists in k8s. Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>

annakhm · 2022-05-03T16:19:21Z

/test-e2e

annakhm · 2022-05-03T23:54:11Z

/test-flexible-ipam-e2e

tnqn

LGTM

tnqn · 2022-05-05T08:40:11Z

/test-conformance
/test-networkpolicy
/skip-e2e which already succeeded

annakhm marked this pull request as draft April 20, 2022 23:01

annakhm force-pushed the clean-ippools branch from e384cc9 to 472ffe5 Compare April 20, 2022 23:39

annakhm marked this pull request as ready for review April 21, 2022 01:15

annakhm requested review from gran-vmv and jianjuns April 25, 2022 18:17

jianjuns reviewed Apr 26, 2022

View reviewed changes

annakhm force-pushed the clean-ippools branch from 472ffe5 to ba5f52d Compare April 26, 2022 04:39

gran-vmv previously approved these changes Apr 26, 2022

View reviewed changes

tnqn reviewed Apr 26, 2022

View reviewed changes

pkg/controller/ipam/antrea_ipam_controller.go Outdated Show resolved Hide resolved

pkg/controller/ipam/antrea_ipam_controller_test.go Outdated Show resolved Hide resolved

pkg/controller/ipam/antrea_ipam_controller.go Show resolved Hide resolved

gran-vmv added this to the Antrea v1.7 release milestone Apr 27, 2022

annakhm dismissed gran-vmv’s stale review via f08f6d5 April 27, 2022 22:26

annakhm force-pushed the clean-ippools branch from ba5f52d to f08f6d5 Compare April 27, 2022 22:26

jianjuns previously approved these changes Apr 27, 2022

View reviewed changes

tnqn previously approved these changes Apr 28, 2022

View reviewed changes

annakhm dismissed stale reviews from tnqn and jianjuns via 1fce058 April 29, 2022 01:47

annakhm force-pushed the clean-ippools branch from f08f6d5 to 1fce058 Compare April 29, 2022 01:47

tnqn reviewed Apr 29, 2022

View reviewed changes

pkg/controller/ipam/antrea_ipam_controller.go Outdated Show resolved Hide resolved

annakhm force-pushed the clean-ippools branch from 1fce058 to d5b4ff1 Compare April 29, 2022 17:26

annakhm force-pushed the clean-ippools branch from d5b4ff1 to df80c2d Compare May 2, 2022 18:06

Implement garbage collector for IP Pools

aa20ef9

A periodic task would go over all IP Pools and clean up all allocations and reservations for which owner no longer exists in k8s. Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>

annakhm force-pushed the clean-ippools branch from df80c2d to aa20ef9 Compare May 2, 2022 23:25

tnqn approved these changes May 5, 2022

View reviewed changes

tnqn added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. action/release-note Indicates a PR that should be included in release notes. labels May 5, 2022

tnqn merged commit 09d11e9 into antrea-io:main May 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement garbage collector for IP Pools #3672

Implement garbage collector for IP Pools #3672

annakhm commented Apr 20, 2022

codecov-commenter commented Apr 20, 2022 •

edited

annakhm commented Apr 21, 2022

annakhm commented Apr 21, 2022

annakhm commented Apr 25, 2022

annakhm commented Apr 25, 2022

jianjuns left a comment

gran-vmv commented Apr 26, 2022

annakhm commented Apr 26, 2022

tnqn left a comment

tnqn commented Apr 28, 2022

jianjuns commented Apr 28, 2022

annakhm commented Apr 29, 2022

tnqn commented Apr 29, 2022

annakhm commented Apr 29, 2022

annakhm commented Apr 29, 2022

annakhm commented May 2, 2022

annakhm commented May 3, 2022

annakhm commented May 3, 2022

tnqn left a comment

tnqn commented May 5, 2022

Implement garbage collector for IP Pools #3672

Implement garbage collector for IP Pools #3672

Conversation

annakhm commented Apr 20, 2022

codecov-commenter commented Apr 20, 2022 • edited

Codecov Report

annakhm commented Apr 21, 2022

annakhm commented Apr 21, 2022

annakhm commented Apr 25, 2022

annakhm commented Apr 25, 2022

jianjuns left a comment

Choose a reason for hiding this comment

gran-vmv commented Apr 26, 2022

annakhm commented Apr 26, 2022

tnqn left a comment

Choose a reason for hiding this comment

tnqn commented Apr 28, 2022

jianjuns commented Apr 28, 2022

annakhm commented Apr 29, 2022

tnqn commented Apr 29, 2022

annakhm commented Apr 29, 2022

annakhm commented Apr 29, 2022

annakhm commented May 2, 2022

annakhm commented May 3, 2022

annakhm commented May 3, 2022

tnqn left a comment

Choose a reason for hiding this comment

tnqn commented May 5, 2022

codecov-commenter commented Apr 20, 2022 •

edited