Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start AntreaProxy document #3679

Merged
merged 2 commits into from Apr 26, 2022
Merged

Conversation

antoninbas
Copy link
Contributor

We add some initial documentation which is long overdue. This is
user-facing documentation and does not cover implementation specifics.

Most notably, it includes information about the configuration options
for AntreaProxy and how they service different use cases.

Signed-off-by: Antonin Bas abas@vmware.com

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #3679 (3e0134e) into main (052987a) will decrease coverage by 5.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3679      +/-   ##
==========================================
- Coverage   58.61%   52.96%   -5.65%     
==========================================
  Files         278      392     +114     
  Lines       39498    55063   +15565     
==========================================
+ Hits        23150    29163    +6013     
- Misses      14491    23572    +9081     
- Partials     1857     2328     +471     
Flag Coverage Δ
integration-tests 38.26% <ø> (?)
kind-e2e-tests 40.91% <ø> (+0.32%) ⬆️
unit-tests 43.86% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/networkpolicy/store/addressgroup.go 83.72% <0.00%> (-3.49%) ⬇️
pkg/agent/flowexporter/connections/conntrack.go 85.71% <0.00%> (-2.86%) ⬇️
pkg/agent/openflow/client.go 62.00% <0.00%> (-1.59%) ⬇️
pkg/agent/route/route_linux.go 28.00% <0.00%> (-1.58%) ⬇️
pkg/apiserver/storage/ram/store.go 78.71% <0.00%> (-1.49%) ⬇️
...pkg/agent/cniserver/ipam/antrea_ipam_controller.go 0.00% <0.00%> (ø)
...ea/pkg/agent/flowexporter/connections/conntrack.go 0.00% <0.00%> (ø)
antrea/pkg/agent/cniserver/ipam/testing/utils.go 92.85% <0.00%> (ø)
antrea/pkg/agent/openflow/egress.go 77.77% <0.00%> (ø)
antrea/pkg/agent/flowexporter/utils.go 14.89% <0.00%> (ø)
... and 117 more

Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!


There are two important prerequisites for this feature:

* You must enabled `proxyAll` and [remove kube-proxy](#removing-kube-proxy) from
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have enabled

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

* Due to some restrictions on the implementation of Services in Antrea, the
maximum number of Endpoints that Antrea can support at the moment is 800. If
the number of Endpoints for a given Service exceeds 800, extra Endpoints will
be dropped. This will be fixed eventually.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
be dropped. This will be fixed eventually.
be dropped (remote endpoints are preferentially dropped). This will be fixed eventually.

tnqn
tnqn previously approved these changes Apr 25, 2022
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

We add some initial documentation which is long overdue. This is
user-facing documentation and does not cover implementation specifics.

Most notably, it includes information about the configuration options
for AntreaProxy and how they service different use cases.

Signed-off-by: Antonin Bas <abas@vmware.com>
Signed-off-by: Antonin Bas <abas@vmware.com>
@antoninbas
Copy link
Contributor Author

Thanks for reviews, I have addressed comments

@antoninbas
Copy link
Contributor Author

/skip-all

Copy link
Contributor

@hongliangl hongliangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor Author

/skip-all

@antoninbas antoninbas merged commit c26a4fe into antrea-io:main Apr 26, 2022
@antoninbas antoninbas deleted the add-antrea-proxy-doc branch April 26, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants