New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start AntreaProxy document #3679
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3679 +/- ##
==========================================
- Coverage 58.61% 52.96% -5.65%
==========================================
Files 278 392 +114
Lines 39498 55063 +15565
==========================================
+ Hits 23150 29163 +6013
- Misses 14491 23572 +9081
- Partials 1857 2328 +471
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
docs/antrea-proxy.md
Outdated
|
||
There are two important prerequisites for this feature: | ||
|
||
* You must enabled `proxyAll` and [remove kube-proxy](#removing-kube-proxy) from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
docs/antrea-proxy.md
Outdated
* Due to some restrictions on the implementation of Services in Antrea, the | ||
maximum number of Endpoints that Antrea can support at the moment is 800. If | ||
the number of Endpoints for a given Service exceeds 800, extra Endpoints will | ||
be dropped. This will be fixed eventually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be dropped. This will be fixed eventually. | |
be dropped (remote endpoints are preferentially dropped). This will be fixed eventually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
We add some initial documentation which is long overdue. This is user-facing documentation and does not cover implementation specifics. Most notably, it includes information about the configuration options for AntreaProxy and how they service different use cases. Signed-off-by: Antonin Bas <abas@vmware.com>
Signed-off-by: Antonin Bas <abas@vmware.com>
f4083bd
to
3e0134e
Compare
Thanks for reviews, I have addressed comments |
/skip-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/skip-all |
We add some initial documentation which is long overdue. This is
user-facing documentation and does not cover implementation specifics.
Most notably, it includes information about the configuration options
for AntreaProxy and how they service different use cases.
Signed-off-by: Antonin Bas abas@vmware.com