Navigation Menu

Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Pay attention to Vary headers for caching of sub-responses #103

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 7 comments
Closed

Comments

@GoogleCodeExporter
Copy link

Our sub-requests currently do not pay attention to Vary response headers. We 
should, especially for things like user-agent.

This is probably not a problem yet, since all of our sub-requests probably have 
the same request-headers, but if we want to add more information to those 
request headers (or pass through user request headers) it will be.

Original issue reported on code.google.com by sligocki@google.com on 19 Nov 2010 at 11:27

@GoogleCodeExporter
Copy link
Author

Original comment by nfor...@google.com on 24 May 2011 at 5:53

@GoogleCodeExporter
Copy link
Author

Ditto: has this been fixed?

Original comment by jmaes...@google.com on 15 Jul 2011 at 1:57

@GoogleCodeExporter
Copy link
Author

If the issue here is whether or not we propagate the user-agent when we make 
requests, then no, I do not believe that it's fixed.

Original comment by nfor...@google.com on 15 Jul 2011 at 5:50

@GoogleCodeExporter
Copy link
Author

I believe this is fixed now; nforman, can you verify this when you get back?

Original comment by jmaes...@google.com on 5 Aug 2011 at 7:31

@GoogleCodeExporter
Copy link
Author

What exactly do you mean by "sub-requests"?  Requests made for resources 
referenced by HTML?

Original comment by nfor...@google.com on 9 Jan 2012 at 3:55

@GoogleCodeExporter
Copy link
Author

Hm, let's see if I can divine what I as thinking a year and a half ago :)

I'm guessing this was about not respecting Vary headers in responses from 
resources referenced by HTML.

Original comment by sligocki@google.com on 9 Jan 2012 at 4:04

  • Added labels: Type-Enhancement
  • Removed labels: Type-Other

@GoogleCodeExporter
Copy link
Author

I believe this has been fixed for quite some time, at least with RespectVary on.

Original comment by jmara...@google.com on 31 Jan 2014 at 2:26

  • Changed state: Fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant