Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

rewrite_css creates error in http://www.androidacademy.com #149

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 8 comments
Closed

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?

1 In one tab, open up http://www.androidacademy.com
2.In another tab, open up 
http://www.androidacademy.com?ModPagespeedFilters=rewrite_css
3.Flip back and forth between the tabs; notice the visual difference in 2nd row 
icon background

What is the expected output? What do you see instead?

Expected: light gray background on second row of icons
Instead:     white background

What version of the product are you using (please check X-Mod-Pagespeed
header)?

0.9.11.5-293 

Please provide any additional information below, especially a URL or an
HTML file that exhibits the problem.

This problem is also repro'd on http://test.androidacademy.com/ but that site 
may need to become password protected soon.





Original issue reported on code.google.com by jmara...@google.com on 11 Dec 2010 at 12:26

@GoogleCodeExporter
Copy link
Author

Looks like the problem is that one of the rewritten resources is getting a name 
that's too long:


Request URL:
http://www.androidacademy.com/components,,_com_jcomments,,_tpl,,_default,,_style
.css,,qv==12+plugins,,_content,,_plg_jv_facebook,,_assets,,_css,,_style.css+plug
ins,,_content,,_bmsmanager,,_classic.css+,,_modules,,_mod_ninja_simple_icon_menu
,,_assets,,_style.css,Mcc.wVmxwnVChe.css.pagespeed.cf.KAoGyLrH6W.css

Request Method:
GET
Status Code:
403 Forbidden

While with only CSS combining:

Request URL:
http://www.androidacademy.com/components,_com_jcomments,_tpl,_default,_style.css
,qv==12+plugins,_content,_plg_jv_facebook,_assets,_css,_style.css+plugins,_conte
nt,_bmsmanager,_classic.css+,_modules,_mod_ninja_simple_icon_menu,_assets,_style
.css.pagespeed.cc.wVmxwnVChe.css

Request Method:
GET
Status Code:
200 OK


/components,,_com_jcomments,,_tpl,,_default,,_style.css,,qv==12+plugins,,_conten
t,,_plg_jv_facebook,,_assets,,_css,,_style.css+plugins,,_content,,_bmsmanager,,_
classic.css+,,_modules,,_mod_ninja_simple_icon_menu,,_assets,,_style.css,Mcc.wVm
xwnVChe.css.pagespeed.cf.KAoGyLrH6W.css is 280 chars long which is more than 
the 256 or so that Apache allows.

Original comment by sligocki@google.com on 20 Dec 2010 at 9:28

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Your specific case should be fixed by r323 in the trunk.

However, there is still an issue that only css_combine checks for URL length. 
I'm changing this bug over to be a fix for that in general.

Original comment by sligocki@google.com on 22 Dec 2010 at 4:00

  • Changed title: Filters need to check that they do not make URLs that are too long
  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Original comment by jmara...@google.com on 22 Dec 2010 at 4:16

  • Added labels: release-note

@GoogleCodeExporter
Copy link
Author

Issue 140 has been merged into this issue.

Original comment by jmaes...@google.com on 28 Dec 2010 at 10:38

@GoogleCodeExporter
Copy link
Author

Original comment by sligocki@google.com on 28 Dec 2010 at 10:41

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Original comment by abl...@google.com on 7 Jan 2011 at 7:27

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Marking this as fixed, since it should fix you (and most) situations. But I 
opened Issue 181 for making all filters check that URLs aren't too long. 

Original comment by sligocki@google.com on 7 Jan 2011 at 7:30

@GoogleCodeExporter
Copy link
Author

Issue 140 has been merged into this issue.

Original comment by jmaes...@google.com on 19 Dec 2013 at 1:42

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant