Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Avoid insertions (e.g., beacon) at midpoint of the document which ought to be at the end of it #857

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

Don't improperly call SummariesDone for every flush window in cases
involving filters deleting slots (e.g. CSS combiner) and multiple
flush windows --- it's supposed to be called only at the very end.

This could potentially lead to multiple beacon insertions, and also
to really confused HTML parser, since we were trying to do
Insertion-at-body-end at a midpoint of document, which spammed loadtest
with "HtmlElement Parents of ..." warnings.

Original issue reported on code.google.com by hui...@google.com on 6 Jan 2014 at 4:21

@GoogleCodeExporter
Copy link
Author

This issue was fixed in r3665.

Original comment by hui...@google.com on 6 Jan 2014 at 4:21

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Original comment by hui...@google.com on 6 Jan 2014 at 4:28

  • Changed title: Avoid insertions (e.g., beacon) at midpoint of the document which ought to be at the end of it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant