Add a public NumericDocValuesRangeQuery class #15479
Merged
+62
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SortedNumericDocValuesRangeQuery and IndexSortSortedNumericDocValuesRangeQuery both implement queries over ranges of numeric doc values, but they cannot be easily introspected. This commit adds a common base class which exposes the field, lowerValue and upperValue of the query.
HoustonPutman
approved these changes
Dec 5, 2025
Contributor
HoustonPutman
left a comment
HoustonPutman
left a comment
There was a problem hiding this comment.
The equals method could probably be moved up, but not a big deal keeping it in each sub-class.
Contributor
Author
Query classes generally do type equality as well so best to keep it separate I think. |
romseygeek
added a commit
that referenced
this pull request
Dec 8, 2025
SortedNumericDocValuesRangeQuery and IndexSortSortedNumericDocValuesRangeQuery both implement queries over ranges of numeric doc values, but they cannot be easily introspected. This commit adds a common base class which exposes the field, lowerValue and upperValue of the query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SortedNumericDocValuesRangeQuery and IndexSortSortedNumericDocValuesRangeQuery
both implement queries over ranges of numeric doc values, but they cannot be easily
introspected. This commit adds a common base class which exposes the field, lowerValue
and upperValue of the query.
This can be useful for things like queryparsers which can automatically rewrite multiple
overlapping queries into single instances.