[FEATURE] - Additional Controller Secrets #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently unless you override the template there is no way of the platform team getting additional secrets in the execution of the terraform jobs. With this PR we've added a command line options --additional-secret which is always added into the executor terraform container.
gambol99
force-pushed
the
feat_additional_secrets
branch
from
09836c7
to
6dd891a
Compare
additional executor secrets on the command line via values.yaml
gambol99
added a commit
that referenced
this pull request
Jul 4, 2022
* [FEATURE] - Additional Controller Secrets
Currently unless you override the template there is no way of the platform team getting
additional secrets in the execution of the terraform jobs. With this PR we've added
a command line options --additional-secret which is always added into the executor
terraform container.
* - updating the chart to include the value and the ability to set the
additional executor secrets on the command line via values.yaml
gambol99
added a commit
that referenced
this pull request
Jul 5, 2022
* [FEATURE] - Additional Controller Secrets
Currently unless you override the template there is no way of the platform team getting
additional secrets in the execution of the terraform jobs. With this PR we've added
a command line options --additional-secret which is always added into the executor
terraform container.
* - updating the chart to include the value and the ability to set the
additional executor secrets on the command line via values.yaml
gambol99
added a commit
that referenced
this pull request
Jul 6, 2022
* [FEATURE] - Additional Controller Secrets
Currently unless you override the template there is no way of the platform team getting
additional secrets in the execution of the terraform jobs. With this PR we've added
a command line options --additional-secret which is always added into the executor
terraform container.
* - updating the chart to include the value and the ability to set the
additional executor secrets on the command line via values.yaml
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently unless you override the template there is no way of the platform team getting
additional secrets in the execution of the terraform jobs. With this PR we've added
a command line options --executor-secret which is always added into the executor
terraform container.