Skip to content

Commit

Permalink
Don't freeze broken scripts
Browse files Browse the repository at this point in the history
Instead, continue with the next line.

Our script parsing is slightly stricter than the original AF and doesn't
allow commands to span multiple lines. This only affects a few scripts
with newlines between the wrong tokens, some of which already have
script warning suppressions - and we already continued with the next
line if there was a script warning suppression defined.

These peculiar newline positions should be fixed in the actual scripts
once we have the infrastructure for that. Until then, they can be
collected as script warning suppressions.

Fixes: bug #584
  • Loading branch information
dscharrer committed Nov 21, 2013
1 parent 7bdfb53 commit bf9b046
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions src/script/ScriptEvent.cpp
Expand Up @@ -457,12 +457,6 @@ ScriptResult ScriptEvent::send(EERIE_SCRIPT * es, ScriptMessage msg, const std::

ScriptEventWarning << "<-- unknown command: " << word;

// TODO(broken-scripts)
if(!isSuppressed(context, word)) {
io->ioflags |= IO_FREEZESCRIPT;
return REFUSE;
}

context.skipCommand();
}

Expand Down

0 comments on commit bf9b046

Please sign in to comment.