@@ -6,13 +6,13 @@ module MetaOnRails def display_meta(default = {}) meta = default.merge(@meta||{}).reject{|k,v|v.blank?} meta.map do |key,value| - "<meta name=\"#{key}\" content=\"#{normalize(value)}\" />" + %Q[<meta name="#{key}" content="#{normalize(value)}"/>] end.join("\n") end private def normalize(s) - s.gsub(/<\/?[^>]*>/, '') + s.gsub(/<\/?[^>]*>/, '').gsub('"',"'") end end lib/meta_on_rails.rb @@ -8,7 +8,7 @@ class MetaOnRailsTest < Test::Unit::TestCase def test_should_have_default_values output = display_meta(:keywords => 'default') - assert output.include?("<meta name=\"keywords\" content=\"default\"") + assert output.include?('<meta name="keywords" content="default"') end def test_should_strip_html @@ -32,4 +32,8 @@ class MetaOnRailsTest < Test::Unit::TestCase def test_does_not_display_blank_values assert_equal display_meta(:keywords => ' '),'' end -end + + def test_removes_double_quotes + assert display_meta(:keywords => '""') =~ %r[content="''"/>] + end +end \ No newline at end of file test/meta_on_rails_test.rb 34e302f1807c1a757c32cd67c869e1b134bfc5fb grosser grosser.michael@gmail.com http://github.com/ashchan/meta_on_rails/commit/4ec6e24fe9fb9c4dcd1f306bb34b2b64dc0997e4 4ec6e24fe9fb9c4dcd1f306bb34b2b64dc0997e4 2009-01-30T06:23:23-08:00 2009-01-30T06:06:54-08:00 escape douple quotes or else keywords spill out... Signed-off-by: James Chan <ashchan@gmail.com> 349b66cfa46c67796f6d0c3397fa2ff0add41ef6 James Chan ashchan@gmail.com