activerecord/test/migrations/duplicate_names/20080507052938_chunky.rb activerecord/test/migrations/duplicate_names/20080507053028_chunky.rb @@ -8,6 +8,12 @@ module ActiveRecord end end + class DuplicateMigrationNameError < ActiveRecordError#:nodoc: + def initialize(name) + super("Multiple migrations have the name #{name}") + end + end + class UnknownMigrationVersionError < ActiveRecordError #:nodoc: def initialize(version) super("No migration with version number #{version}") @@ -440,6 +446,10 @@ module ActiveRecord if klasses.detect { |m| m.version == version } raise DuplicateMigrationVersionError.new(version) end + + if klasses.detect { |m| m.name == name.camelize } + raise DuplicateMigrationNameError.new(name.camelize) + end load(file) activerecord/lib/active_record/migration.rb @@ -984,6 +984,12 @@ if ActiveRecord::Base.connection.supports_migrations? end end + def test_migrator_with_duplicate_names + assert_raises(ActiveRecord::DuplicateMigrationNameError, "Multiple migrations have the name Chunky") do + ActiveRecord::Migrator.migrate(MIGRATIONS_ROOT + "/duplicate_names", nil) + end + end + def test_migrator_with_missing_version_numbers assert_raise(ActiveRecord::UnknownMigrationVersionError) do ActiveRecord::Migrator.migrate(MIGRATIONS_ROOT + "/missing", 500) activerecord/test/cases/migration_test.rb 0a21193dc660396fb993b06d1d3c168a9cd900a5 Aslak Hellesøy aslak.hellesoy@gmail.com http://github.com/aslakhellesoy/rails/commit/14c03ba619960693ec73fad7833d1a00562e2c64 14c03ba619960693ec73fad7833d1a00562e2c64 2008-05-06T22:59:34-07:00 2008-05-06T22:59:34-07:00 Detect duplicate migration names when running migrations. This can happen if a migration is renamed after it is created e997a35ebdc3a47f78c9259c74093fb246173ad3 Aslak Hellesøy aslak.hellesoy@gmail.com