Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple signal names #172

Closed
wants to merge 4 commits into from
Closed

Allow multiple signal names #172

wants to merge 4 commits into from

Conversation

niieani
Copy link
Contributor

@niieani niieani commented Dec 20, 2015

Additional signal names must be passed in as additional parameters in the binding behaviour, like: binding & signal:'first':'second':'third'.

Fixes #170.
Note: Individual Contributor License Agreement signed.

@EisenbergEffect
Copy link
Contributor

CLA is confirmed. I can merge pending approval from @jdanyow

@niieani
Copy link
Contributor Author

niieani commented Dec 21, 2015

@EisenbergEffect Still need to add the test and conform to @jdanyow's specs. I'll do that sometime this week.

@EisenbergEffect
Copy link
Contributor

@niieani Had any chance to work on the specs?

@niieani
Copy link
Contributor Author

niieani commented Jan 5, 2016

Hey @EisenbergEffect, Happy New Year to you and the Aurelia team!
I've not had the chance to do that yet, I've been really busy with my project, so for now I've just implemented this locally.
But I'll try to do this properly before the end of January.

@EisenbergEffect
Copy link
Contributor

If you want to work on this, you will need to rebase on master.

@niieani
Copy link
Contributor Author

niieani commented Jan 8, 2016

Yes, I know.
On Fri, 8 Jan 2016 at 15:38, Rob Eisenberg notifications@github.com wrote:

If you want to work on this, you will need to rebase on master.


Reply to this email directly or view it on GitHub
#172 (comment)
.

@jdanyow
Copy link
Contributor

jdanyow commented Jan 16, 2016

@niieani let me know if you want a hand with this- we'd much rather merge your PR though!

@EisenbergEffect
Copy link
Contributor

@niieani Ping...

@niieani
Copy link
Contributor Author

niieani commented Feb 4, 2016

@jdanyow For review.

@EisenbergEffect
Copy link
Contributor

@jdanyow Can you review this now?
@niieani Would you mind rebasing this on master?

@niieani
Copy link
Contributor Author

niieani commented Feb 22, 2016

@EisenbergEffect that's odd, I had already rebased it into a single commit, did you force-push rewritten history on this repo? Anyway, I can do it again, just a bit of a pain this wasn't merged before that happened.

@EisenbergEffect
Copy link
Contributor

I don't think we did anything like that. If you can do it one more time, I'll get it in.

@jdanyow jdanyow closed this in 620614e Feb 25, 2016
@dkent600
Copy link

So this was never done? I'd love to have this kind of functionality at this moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No possibility to use multiple signal names
4 participants