Don't use IO::Scalar but in-memory open(). Using the former breaks PO…

…D + UTF-8
avar · Mar 8, 2010 · 3ec9008 · 3ec9008 · avar · Mar 8, 2010
1 parent e2939a8
commit 3ec9008
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,10 @@
 Revision history for Dist-Zilla-Plugin-ReadmeFromPod
 
+0.05
+        Using IO::Scalar instead of Perl's built-in open() to open
+        in-memory filehandles breaks in-memory Pod::Text processing of
+        POD documents containing UTF-8 (who knows why) (avar)
+
 0.04    2009.06.16
         require Pod::Text 3.13
 

diff --git a/dist.ini b/dist.ini
@@ -11,7 +11,6 @@ remove = BumpVersion
 
 [Prereq]
 Dist::Zilla = 1.007
-IO::Scalar  = 0
 Pod::Text   = 3.13
 
 [PodWeaver]

diff --git a/lib/Dist/Zilla/Plugin/ReadmeFromPod.pm b/lib/Dist/Zilla/Plugin/ReadmeFromPod.pm
@@ -25,12 +25,10 @@ sub setup_installer {
 
   require Dist::Zilla::File::InMemory;
 
-  require IO::Scalar;
-  my $content;
-  my $out_fh = new IO::Scalar \$content;
+  open(my $out_fh, ">", \my $content);
 
   my $mmcontent = $self->zilla->main_module->content;
-  
+
   require Pod::Text;
   my $parser = Pod::Text->new();
   $parser->output_fh( $out_fh );