Enable manual self-updates on new sites

[jenlampton]

This is a follow-up to #3271, and will set the default value for allowing self-updates to TRUE. This will be a requirement for automatic updates.

---

PR: backdrop/backdrop#2441
PR: backdrop/backdrop#2612

[quicksketch]

I think the current PR isn't the right one. Looks like it removes an update hook, rather than adding one.

[jenlampton]

Okay, trying this again. New PR up for review: backdrop/backdrop#2612

[klonos]

The code change is trivial, and the PR sandbox has the setting enabled, so RTBC 👍

Do we need an update hook for this? That would be changing the current behavior of already installed sites. Not a bad thing, since this is not the auto-updates setting.

[jenlampton]

I was thinking: no update hook. Not sure we want to change a value people have already decided against.

…

On Fri, Apr 26, 2019, 1:56 AM Gregory Netsas ***@***.***> wrote: The code change is trivial, and the PR sandbox has the setting enabled, so RTBC 👍 Do we need an update hook for this? That would be changing the current behavior of already installed sites. Not a bad thing, since this is not the auto-updates setting. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3453 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADBER26HEH2B4DXK2QFAD3PSK7U7ANCNFSM4GMWYCSA> .

[klonos]

RTBC then.

@quicksketch or anyone else, please feel free to kick back to NW if you think that we should change that setting for existing sites.

[quicksketch]

Thanks! During the 1.12.x cycle we've definitely proven this functionality works. And when it doesn't (due to permissions usually), it doesn't affect the site negatively, it just throws an error saying it couldn't modify the files. That part definitely has room for improvement, but doesn't block us from enabling this option for new sites.

I don't think we should modify this setting on existing sites, since we have no way of identifying a site-owner's preference. Though really maybe this shouldn't be an option at all in the future. It's either "Allow updates" or not, for everything (both core and contrib). The risk and benefit to your site is equal for both kinds of updates.

[quicksketch]

Merged backdrop/backdrop#2612 into 1.x for 1.13.0.