Skip to content

Commit

Permalink
http2: init the pushed transfer properly
Browse files Browse the repository at this point in the history
  • Loading branch information
bagder committed Jun 24, 2015
1 parent f65ab88 commit e9f0dd4
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 10 deletions.
7 changes: 7 additions & 0 deletions lib/multi.c
Expand Up @@ -958,9 +958,16 @@ CURLMcode Curl_multi_add_perform(struct Curl_multi *multi,

rc = curl_multi_add_handle(multi, data);
if(!rc) {
struct SingleRequest *k = &data->req;

/* pass in NULL for 'conn' here since we don't want to init the
connection, only this transfer */
Curl_init_do(data, NULL);

/* take this handle to the perform state right away */
multistate(data, CURLM_STATE_PERFORM);
data->easy_conn = conn;
k->keepon |= KEEP_RECV; /* setup to receive! */
}
return rc;
}
Expand Down
21 changes: 12 additions & 9 deletions lib/url.c
Expand Up @@ -142,7 +142,6 @@ find_oldest_idle_connection_in_bundle(struct SessionHandle *data,
struct connectbundle *bundle);
static void conn_free(struct connectdata *conn);
static void signalPipeClose(struct curl_llist *pipeline, bool pipe_broke);
static CURLcode do_init(struct connectdata *conn);
static CURLcode parse_url_login(struct SessionHandle *data,
struct connectdata *conn,
char **userptr, char **passwdptr,
Expand Down Expand Up @@ -5651,7 +5650,7 @@ static CURLcode create_conn(struct SessionHandle *data,
}

/* since we skip do_init() */
do_init(conn);
Curl_init_do(data, conn);

goto out;
}
Expand Down Expand Up @@ -5830,7 +5829,7 @@ static CURLcode create_conn(struct SessionHandle *data,
conn->inuse = TRUE;

/* Setup and init stuff before DO starts, in preparing for the transfer. */
do_init(conn);
Curl_init_do(data, conn);

/*
* Setup whatever necessary for a resumed transfer
Expand Down Expand Up @@ -6112,20 +6111,24 @@ CURLcode Curl_done(struct connectdata **connp,
}

/*
* do_init() inits the readwrite session. This is inited each time (in the DO
* function before the protocol-specific DO functions are invoked) for a
* transfer, sometimes multiple times on the same SessionHandle. Make sure
* Curl_init_do() inits the readwrite session. This is inited each time (in
* the DO function before the protocol-specific DO functions are invoked) for
* a transfer, sometimes multiple times on the same SessionHandle. Make sure
* nothing in here depends on stuff that are setup dynamically for the
* transfer.
*
* Allow this function to get called with 'conn' set to NULL.
*/

static CURLcode do_init(struct connectdata *conn)
CURLcode Curl_init_do(struct SessionHandle *data, struct connectdata *conn)
{
struct SessionHandle *data = conn->data;
struct SingleRequest *k = &data->req;

if(conn)
conn->bits.do_more = FALSE; /* by default there's no curl_do_more() to
* use */

data->state.done = FALSE; /* Curl_done() is not called yet */
conn->bits.do_more = FALSE; /* by default there's no curl_do_more() to use */
data->state.expect100header = FALSE;

if(data->set.opt_no_body)
Expand Down
3 changes: 2 additions & 1 deletion lib/url.h
Expand Up @@ -7,7 +7,7 @@
* | (__| |_| | _ <| |___
* \___|\___/|_| \_\_____|
*
* Copyright (C) 1998 - 2013, Daniel Stenberg, <daniel@haxx.se>, et al.
* Copyright (C) 1998 - 2015, Daniel Stenberg, <daniel@haxx.se>, et al.
*
* This software is licensed as described in the file COPYING, which
* you should have received as part of this distribution. The terms
Expand All @@ -27,6 +27,7 @@
* Prototypes for library-wide functions provided by url.c
*/

CURLcode Curl_init_do(struct SessionHandle *data, struct connectdata *conn);
CURLcode Curl_open(struct SessionHandle **curl);
CURLcode Curl_init_userdefined(struct UserDefined *set);
CURLcode Curl_setopt(struct SessionHandle *data, CURLoption option,
Expand Down

0 comments on commit e9f0dd4

Please sign in to comment.