Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken link in pod as reported by CPANTS. #15

Merged
merged 1 commit into from Apr 16, 2019
Merged

Fixed broken link in pod as reported by CPANTS. #15

merged 1 commit into from Apr 16, 2019

Conversation

manwar
Copy link
Contributor

@manwar manwar commented Apr 15, 2019

Hi @balajirama

Please review the PR.
https://cpants.cpanauthors.org/release/BALAJIRAM/Text-Parser-0.915

Many Thanks.
Best Regards,
Mohammad S Anwar

@codecov
Copy link

codecov bot commented Apr 15, 2019 •
edited

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #15   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         161    161           
  Branches       39     39           
=====================================
  Hits          161    161
Impacted Files Coverage Δ
lib/Text/Parser/Errors.pm 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c874827...f49fedd. Read the comment docs.

@balajirama balajirama self-assigned this Apr 16, 2019
@balajirama balajirama added the documentation This is an improvement to the documentation label Apr 16, 2019
@balajirama
Copy link
Owner

Thanks a lot @manwar

The PR seems okay. But did you notice that v0.916 is already out and that too has this bug. And between that and now, I have already committed some changes to master. Will the merge be done properly? I wonder. What do you think?

@balajirama
Copy link
Owner

Let me try to merge.

@balajirama balajirama merged commit 04db9ce into balajirama:master Apr 16, 2019
@balajirama
Copy link
Owner

It worked! Thanks a lot.

@balajirama
Copy link
Owner

By the way, there is one more broken link for save_record in Text::Parser::Autosplit

@balajirama
Copy link
Owner

I have fixed that bug also. Thanks for this.

@balajirama
Copy link
Owner

New release 0.917 will come out tonight.

balajirama added a commit that referenced this pull request Apr 16, 2019
@balajirama
v0.917
538e4b8 
  - Fixed broken link in pod as reported by CPANTS. #15 (by M Anwar)
  - Fixed a similar broken link in pod as reported in CPANTS for save_record from Autoplit.pm
  - Added a new test to check that when both auto_split and auto_trim are on, auto_trim works first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@balajirama balajirama

Labels
documentation This is an improvement to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manwar @balajirama