From d4ee3416e56070dec2874be2037d9129dd4d0e09 Mon Sep 17 00:00:00 2001
From: Frank Bergkemper <frank.bergkemper@bareos.com>
Date: Fri, 30 Sep 2016 14:07:04 +0200
Subject: [PATCH] update check: topnavbar alert msg

Displays an alert in topnavbar in case the update data
could not be retrieved.
---
 .../src/Application/View/Helper/UpdateAlert.php    | 14 ++++++++++----
 module/Application/view/layout/layout.phtml        |  2 +-
 module/Auth/src/Auth/Controller/AuthController.php |  7 ++++++-
 3 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/module/Application/src/Application/View/Helper/UpdateAlert.php b/module/Application/src/Application/View/Helper/UpdateAlert.php
index 6bc85926..27fd1ce1 100644
--- a/module/Application/src/Application/View/Helper/UpdateAlert.php
+++ b/module/Application/src/Application/View/Helper/UpdateAlert.php
@@ -32,11 +32,17 @@ class UpdateAlert extends AbstractHelper
    protected $value;
    protected $result;
 
-   public function __invoke($value)
+   public function __invoke($a=null,$b=null)
    {
-      if($value) {
-         $this->result = '<a data-toggle="tooltip" data-placement="bottom" href="http://download.bareos.com/" target="_blank"title="Updates available"><span class="glyphicon glyphicon-exclamation-sign text-danger" aria-hidden="true"></span></a>';
-         return $this->result;
+      if($a) {
+         if($b) {
+            $this->result = '<a data-toggle="tooltip" data-placement="bottom" href="http://download.bareos.com/" target="_blank"title="Updates available"><span class="glyphicon glyphicon-exclamation-sign text-danger" aria-hidden="true"></span></a>';
+            return $this->result;
+         }
+      }
+      else {
+         $this->result = '<a data-toggle="tooltip" data-placement="bottom" href="http://download.bareos.com/" target="_blank"title="Update informaton could not be retrieved"><span class="glyphicon glyphicon-exclamation-sign text-danger" aria-hidden="true"></span></a>';
+            return $this->result;
       }
    }
 }
diff --git a/module/Application/view/layout/layout.phtml b/module/Application/view/layout/layout.phtml
index 2efb0947..765b2bcc 100644
--- a/module/Application/view/layout/layout.phtml
+++ b/module/Application/view/layout/layout.phtml
@@ -81,7 +81,7 @@ echo $this->doctype();
          <?php echo $this->navigation('navigation')->menu()->setMinDepth(0)->setMaxDepth(0)->setUlClass('nav navbar-nav'); ?>
          <ul class="nav navbar-nav navbar-right">
             <li class="dropdown">
-               <?php echo $this->UpdateAlert($_SESSION['bareos']['dird-update-available']); ?>
+               <?php echo $this->UpdateAlert($_SESSION['bareos']['product-updates-status'],$_SESSION['bareos']['dird-update-available']); ?>
             </li>
             <li class="dropdown">
                <a href="#"><span class="glyphicon glyphicon-th"></span>&nbsp;<?php echo $_SESSION['bareos']['director']; ?></a>
diff --git a/module/Auth/src/Auth/Controller/AuthController.php b/module/Auth/src/Auth/Controller/AuthController.php
index fcfb8c1f..1a1f1e6d 100644
--- a/module/Auth/src/Auth/Controller/AuthController.php
+++ b/module/Auth/src/Auth/Controller/AuthController.php
@@ -86,7 +86,8 @@ public function loginAction()
                $_SESSION['bareos']['product-updates'] = $bareos_updates;
                $_SESSION['bareos']['dird-update-available'] = false;
 
-               if(isset($bareos_updates) && $bareos_updates != NULL) {
+               if(isset($bareos_updates) && $bareos_updates != false) {
+                  $_SESSION['bareos']['product-updates-status'] = true;
                   $updates = json_decode($bareos_updates, true);
 
                   try {
@@ -126,6 +127,10 @@ public function loginAction()
                      }
                   }
                }
+               else {
+                  // updates could not be retrieved by ajax call
+                  $_SESSION['bareos']['product-updates-status'] = false;
+               }
 
                // Get the config.
                $configuration = $this->getServiceLocator()->get('configuration');