From 3a563720c5384d9b59d29a501333b2d0e19b3b09 Mon Sep 17 00:00:00 2001
From: gnieark <gnieark@free.fr>
Date: Tue, 13 Jul 2021 09:51:49 +0200
Subject: [PATCH] webui: quote strings with slashes in media details view

(cherry picked from commit a3fd053f40760d175ca1d9dcfc8a352fc9bef6b8)

Fixes #1235: Special characters not escaped in translations
---
 .../Media/view/media/media/details.phtml      | 58 +++++++++----------
 1 file changed, 29 insertions(+), 29 deletions(-)

diff --git a/webui/module/Media/view/media/media/details.phtml b/webui/module/Media/view/media/media/details.phtml
index d800b7a957c..a1c0343878b 100644
--- a/webui/module/Media/view/media/media/details.phtml
+++ b/webui/module/Media/view/media/media/details.phtml
@@ -274,119 +274,119 @@ $this->headTitle($title);
       html.push('<div class="container-fluid">');
       html.push('<table class="table table-bordered">');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Label date"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Label date")); ?></th>');
       html.push('<td>' + row.labeldate + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("First written"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("First written")); ?></th>');
       html.push('<td>' + row.firstwritten + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Last written"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Last written")); ?></th>');
       html.push('<td>' + row.lastwritten + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Volume jobs"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Volume jobs")); ?></th>');
       html.push('<td>' + row.voljobs + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Recycle"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Recycle")); ?></th>');
       html.push('<td>' + r + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Volume writes"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Volume writes")); ?></th>');
       html.push('<td>' + row.volwrites + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Slot"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Slot")); ?></th>');
       html.push('<td>' + row.slot + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Media Id"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Media Id")); ?></th>');
       html.push('<td>' + row.mediaid + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Volume Blocks"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Volume Blocks")); ?></th>');
       html.push('<td>' + row.volblocks + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Volume use duration"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Volume use duration")); ?></th>');
       html.push('<td>' + row.voluseduration + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Volume Pool Id"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Volume Pool Id")); ?></th>');
       html.push('<td>' + row.poolid + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("In changer"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("In changer")); ?></th>');
       html.push('<td>' + row.inchanger + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Volume Files"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Volume Files")); ?></th>');
       html.push('<td>' + row.volfiles + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Max. volume jobs"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Max. volume jobs")); ?></th>');
       html.push('<td>' + row.maxvoljobs + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Volume mounts"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Volume mounts")); ?></th>');
       html.push('<td>' + row.volmounts + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Volume capacity bytes"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Volume capacity bytes")); ?></th>');
       html.push('<td>' + row.volcapacitybytes + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Volume errors"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Volume errors")); ?></th>');
       html.push('<td>' + row.volerrors + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Enabled"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Enabled")); ?></th>');
       html.push('<td>' + row.enabled + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Max. volume files"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Max. volume files")); ?></th>');
       html.push('<td>' + row.maxvolfiles + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Endfile"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Endfile")); ?></th>');
       html.push('<td>' + row.endfile + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Endblock"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Endblock")); ?></th>');
       html.push('<td>' + row.endblock + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Labeltype"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Labeltype")); ?></th>');
       html.push('<td>' + row.labeltype + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Device Id"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Device Id")); ?></th>');
       html.push('<td>' + row.deviceid + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Location Id"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Location Id")); ?></th>');
       html.push('<td>' + row.locationid + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Recycle count"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Recycle count")); ?></th>');
       html.push('<td>' + row.recyclecount + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Initial write"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Initial write")); ?></th>');
       html.push('<td>' + row.initialwrite + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Scratch Pool Id"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Scratch Pool Id")); ?></th>');
       html.push('<td>' + row.scratchpoolid + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Recycle Pool Id"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Recycle Pool Id")); ?></th>');
       html.push('<td>' + row.recyclepoolid + '</td>');
       html.push('</tr>');
       html.push('<tr>');
-      html.push('<th><?php echo $this->translate("Comment"); ?></th>');
+      html.push('<th><?php echo addslashes($this->translate("Comment")); ?></th>');
       html.push('<td>' + row.comment + '</td>');
       html.push('</tr>');
       html.push('</table>');