fix not enough arguments for shift

bareos · Jan 8, 2016 · a040767 · a040767
1 parent f2cbdcb
commit a040767
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 9 deletions.
diff --git a/debian/bareos-database-common.config.in b/debian/bareos-database-common.config.in
@@ -30,12 +30,16 @@ if [ -r @scriptdir@/bareos-config-lib.sh ]; then
         dbc_dbtypes=`echo ${dbc_dbtypes} | sed 's/, *$//'`
 
         # action
-        param1="$1"
-        shift || true
+        if [ $# -gt 0 ]; then
+            param1="$1"
+            shift
+        fi
         # $2: when action is "configure": most-recently-configured-version
-        param2="$1"
-        param2_orig=$param2
-        shift || true
+        if [ $# -gt 0 ]; then
+            param2="$1"
+            param2_orig=$param2
+            shift
+        fi
 
         # When upgrading from an older version (param2),
         # do not pass the version number of the old package.

diff --git a/debian/bareos-database-common.postinst.in b/debian/bareos-database-common.postinst.in
@@ -25,11 +25,15 @@ if [ -r @scriptdir@/bareos-config-lib.sh ]; then
         . /usr/share/dbconfig-common/dpkg/postinst
 
         # action
-        param1="$1"
-        shift || true
+        if [ $# -gt 0 ]; then
+            param1="$1"
+            shift
+        fi
         # when action is "configure": most-recently-configured-version
-        param2="$1"
-        shift || true
+        if [ $# -gt 0 ]; then
+            param2="$1"
+            shift
+        fi
         if [ "$param2" ]; then
             case "$param1" in
                 configure|reconfigure)