@@ -257,7 +257,7 @@ class EmailReport(webapp.RequestHandler): return None def send_email(self, pid, subject, email_body): - message = mail.EmailMessage(sender=settings.PRODUCTS[pid]['from_address'], + message = mail.EmailMessage(sender=settings.SETTINGS['admin_email_address'], subject=subject) message.to = settings.PRODUCTS[pid]['to_addresses'] message.html = email_body jobs/email_report.py @@ -2,7 +2,8 @@ import wsgiref.handlers from google.appengine.ext import webapp from google.appengine.ext.webapp.util import login_required from google.appengine.api import urlfetch -from google.appengine.api.labs import taskqueue +from google.appengine.api import mail + import datetime import sys @@ -14,18 +15,22 @@ from processors import report_persister class ReportJob(webapp.RequestHandler): def get(self): + # iTunes Connect stores reports with a 1 day delay + now = datetime.date.today() + one_day = datetime.timedelta(days=1) + yesterday = now - one_day + yesterday = yesterday.strftime('%m/%d/%Y') try: - # iTunes Connect stores reports with a 1 day delay - now = datetime.date.today() - one_day = datetime.timedelta(days=1) - yesterday = now - one_day - yesterday = yesterday.strftime('%m/%d/%Y') latest_report = itcscrape.getLastDayReport(settings.SETTINGS['itunesconnect_username'], settings.SETTINGS['itunesconnect_password'], yesterday) report_persister.persist(latest_report['filename'], latest_report['content']) - except urlfetch.DownloadError: - # Download failed most likely due to a timeout - # Add to the task queue to keep trying to download the report - taskqueue.add(url='/jobs/pull_report', method='GET') + except: + # Download failed (timeout or report not available yet) + # Send email to administrator + message = mail.EmailMessage(sender=settings.SETTINGS['admin_email_address'], + subject='[ASM] Report job failed for: ' + yesterday) + message.to = settings.SETTINGS['admin_email_address'] + message.body = 'Failed to download the iTunes Connect sales report for: ' + yesterday + message.send() def main(): application = webapp.WSGIApplication([('/jobs/pull_report', ReportJob)], debug=True) jobs/pull_report.py @@ -13,6 +13,9 @@ SETTINGS = { # Your iTunes Connect credentials for the cron job to log in and download your reports daily "itunesconnect_username": "<<username>>", "itunesconnect_password": "<<password>>", + + # This must be the email address of a registered administrator for the application due to mail API restrictions + "admin_email_address": "My Name <sender@example.com>", # Don't change these "template_path": APP_ROOT_DIR + '/templates/', @@ -38,9 +41,6 @@ PRODUCTS = { "versions": [{'name': 'v1.0', 'date': datetime.date(2009, 6, 22)}, {'name': 'v1.1', 'date': datetime.date(2009, 7, 18)}], - # This must be the email address of a registered administrator for the application due to mail API restrictions - "from_address": "My Name <sender@example.com>", - # List of email addresses you would like the daily reports sent to "to_addresses": [ 'Recipient Name <recipient@example.com>', settings.py fd2737d64e2638d71befc1e34afbc1164e9d9ef1 Basil Shkara basil@oiledmachine.com http://github.com/baz/app-sales-machine/commit/c7050da36a10b02ce7dd6f404b895d1e775dda54 c7050da36a10b02ce7dd6f404b895d1e775dda54 2009-11-07T21:21:14-08:00 2009-11-07T21:21:14-08:00 Send email to administrator when download fails. ca6d39e8f633f6e70926b62a740fda9a0541d3f4 Basil Shkara basil@oiledmachine.com