Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Targets sometimes need to add constraints on the execution platform #5217

Closed
katre opened this issue May 18, 2018 · 0 comments
Closed

Targets sometimes need to add constraints on the execution platform #5217

katre opened this issue May 18, 2018 · 0 comments
Assignees
@katre
Labels
P1 I'll work on this now. (Assignee required) type: feature request

Comments

@katre
Copy link
Member

katre commented May 18, 2018

See design doc: https://docs.google.com/document/d/1p1J2ktWTpoKvNATjC6U29vhz1_-Dgbe9YRPr5wisfzY/edit?usp=sharing
@katre katre added type: feature request P1 I'll work on this now. (Assignee required) category: extensibility > toolchains labels May 18, 2018
@katre katre self-assigned this May 18, 2018
@katre katre mentioned this issue May 21, 2018
Closed
bazel-io pushed a commit that referenced this issue Jun 5, 2018
@katre
Allow rules and targets to specify extra execution platform constraints.
ee45c66 
RuleClass.Builder now allows authors to specify whether a rule's targets
can add additional constraints on the execution platform, and to declare
additional constraints for all targets of that rule.

Targets which support this now have an attribute,
"exec_compatible_with", which supports specifying additional constraints
that the execution platform used must match.

This attribute is non-configurable. It will only affect execution
platforms used during toolchain resolution.

Part of #5217.

Change-Id: Id2400dbf869a00aa2be3e3d2f085c2850cd6dc00

Closes #5227.

Change-Id: If7d55f08f7f44bc7d7f6dfec86a3e6bcd68574b9
PiperOrigin-RevId: 199326255
@katre katre closed this as completed Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
P1 I'll work on this now. (Assignee required) type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katre