@@ -2,9 +2,14 @@ Todo ---- externals -- docs -- changesets -- what if external dir doesn't exist yet +- 1 + - use revision to see if something has been changed +- 2 + - +- 3 + - optimize external handling + - only use 1 level + - optimize if in same repos Questions --------- doc/tasks.txt @@ -9,7 +9,7 @@ Net::SMTP.class_eval do open_conversation(helodomain) if starttls - create_ssl_socket(@socket, helodomain) + create_ssl_socket(socket, helodomain) else # some SMTP servers that don't support TLS drop the socket after rejecting # STARTTLS command, so reopen the conversation lib/smtp_tls.rb @@ -55,7 +55,7 @@ class Subversion def last_locally_known_revision return Revision.new(0) unless File.exist?(path) - Revision.new(info.last_changed_revision) + Revision.new(info.revision) end def latest_revision @@ -76,7 +76,9 @@ class Subversion if @check_externals externals.each do |ext_path, ext_url| ext_logger = ExternalReasons.new(ext_path, reasons) - ext_svn = Subversion.new(:path => File.join(self.path, ext_path), :url => ext_url) + ext_svn = Subversion.new(:path => File.join(self.path, ext_path), + :url => ext_url, + :check_externals => false) result = false unless ext_svn.up_to_date?(ext_logger) end end lib/subversion.rb @@ -2,7 +2,6 @@ require 'date' require 'xml_simple' class Subversion::LogParser - def parse(lines) return [] if lines.empty? entries = XmlSimple.xml_in(lines.join, 'ForceArray' => ['logentry','path'])['logentry'] || [] lib/subversion/log_parser.rb ddc745f1ad8f36c989d61555c1808afe84ca5bb1 stellsmi stellsmi@c04ce798-636b-4ca8-9149-0f9336831111 http://github.com/benburkert/cruisecontrolrb/commit/3b67766a92bb18994fbd33d131dd8f8a331e31fe 3b67766a92bb18994fbd33d131dd8f8a331e31fe 2008-03-14T16:52:15-07:00 2008-03-14T16:52:15-07:00 hopefully fixing a few bugs - revision should depend on being bigger than actual revision, not last change, external checking should not recurse, and ssl socket still seems broken git-svn-id: http://cruisecontrolrb.rubyforge.org/svn/trunk@610 c04ce798-636b-4ca8-9149-0f9336831111 4ef5398a50843da1122d0792dc6028c64530c4ab stellsmi stellsmi@c04ce798-636b-4ca8-9149-0f9336831111