Issues - binarylogic/authlogic_openid

binarylogic / authlogic_openid

151

Description:

Extension of the Authlogic library to add OpenID support.

Sort by: Priority | Votes | Last Updated

Loading…

3.

5 votes

Missing template user_sessions/create.erb in view path app/views
12 comments Created 6 months ago by taddgiles

Title

Body
authlogic v2.0.13 and authlogic-oid v1.0.4 When I submit an invalid open id to a new session ("goodopenid.com" in my case) I get the following error: Missing template user_sessions/create.erb in view path app/views Here's my user_sessions_controller create method (copied from examples) def create @user_session = UserSession.new(params[:user_session]) # We are saving with a block to accomodate for OpenID authentication # If you are not using OpenID you can save without a block: # # if @user_session.save # # ... successful login # else # # ... unsuccessful login # end @user_session.save do |result| if result flash[:notice] = "Login successful!" redirect_back_or_default root_path else render :action => :new end end end For some reason its attempting to render "create" rather than rendering "new" with errors. Incidentally, I see the same problem in the sample app here: http://authlogicexample.binarylogic.com/ There, when I use "goodopenid.com" I get a crash. Ideas?
or cancel
authlogic v2.0.13 and authlogic-oid v1.0.4

When I submit an invalid open id to a new session ("goodopenid.com" in my case) I get the following error:

Missing template user_sessions/create.erb in view path app/views

Here's my user_sessions_controller create method (copied from examples)

def create
```
@user_session = UserSession.new(params[:user_session])
# We are saving with a block to accomodate for OpenID authentication
# If you are not using OpenID you can save without a block:
#
#   if @user_session.save
#     # ... successful login
#   else
#     # ... unsuccessful login
#   end
@user_session.save do |result|
  if result
    flash[:notice] = "Login successful!"
    redirect_back_or_default root_path
  else
    render :action => :new
  end
end
```
end

For some reason its attempting to render "create" rather than rendering "new" with errors.

Incidentally, I see the same problem in the sample app here:

http://authlogicexample.binarylogic.com/

There, when I use "goodopenid.com" I get a crash.

Ideas?
Comments
Bluejade Thu Jul 09 12:59:20 -0700 2009 | link

This error appeared in a recent update of authlogic_openid. With version 1.0.4, all of my tests pass. With the current version, several things break, including the problem you mention here.

Comment
This error appeared in a recent update of authlogic_openid. With version 1.0.4, all of my tests pass. With the current version, several things break, including the problem you mention here.
or cancel

taddgiles Thu Jul 09 13:31:04 -0700 2009 | link

so your tests pass with authlogic_openid 1.0.4? And which version of authlogic are you using?

Comment
so your tests pass with authlogic_openid 1.0.4? And which version of authlogic are you using?
or cancel

Bluejade Thu Jul 09 16:50:23 -0700 2009 | link

I was using 2.0.14, but have now upgraded to 2.1.1. Both pass all my tests. When I upgrade authlogic_openid to the current version, I get errors and assertion failures. The errors are the same one you report above: missing user_sessions/create.html.erb template.

Comment
I was using 2.0.14, but have now upgraded to 2.1.1. Both pass all my tests. When I upgrade authlogic_openid to the current version, I get errors and assertion failures. The errors are the same one you report above: missing user_sessions/create.html.erb template.
or cancel

dbarison Mon Jul 13 05:25:22 -0700 2009 | link

same problem here, with lastest version.
authlogic 2.1.1 + authlogic-oid 1.0.4 all ok.

Comment
same problem here, with lastest version. authlogic 2.1.1 + authlogic-oid 1.0.4 all ok.
or cancel

taddgiles Mon Jul 13 16:27:55 -0700 2009 | link

yup, confirmed, authlogic 2.0.14 and authlogic-oid 1.0.4 pass for me too.

Comment
yup, confirmed, authlogic 2.0.14 and authlogic-oid 1.0.4 pass for me too.
or cancel

sporkd Tue Jul 14 14:00:30 -0700 2009 | link

I posted something to the google group a while back about a commit that was made almost a month ago... You guys might want to check if it's the same issue I was having.

http://groups.google.com/group/authlogic/browse_thread/thread/fdc8dad50e8cf267/203f774bad6faa46?lnk=gst&q=block#203f774bad6faa46

Comment
I posted something to the google group a while back about a commit that was made almost a month ago... You guys might want to check if it's the same issue I was having. http://groups.google.com/group/authlogic/browse_thread/thread/fdc8dad50e8cf267/203f774bad6faa46?lnk=gst&q=block#203f774bad6faa46
or cancel

dbarison Wed Jul 15 01:43:35 -0700 2009 | link

yes this solution fix this problem, thnx sporkd.
now remains some problems with auto_register enabled.

Comment
yes this solution fix this problem, thnx sporkd. now remains some problems with auto_register enabled.
or cancel

tfe Wed Jul 29 13:01:55 -0700 2009 | link

Is there any chance of this being fixed and released in the official gem? I cannot modify code as in sporkd's link since I don't have control over gems in my deployment environment (Heroku), but can only reference ones that are in the gem repositories.

Comment
Is there any chance of this being fixed and released in the official gem? I cannot modify code as in sporkd's link since I don't have control over gems in my deployment environment (Heroku), but can only reference ones that are in the gem repositories.
or cancel

sporkd Wed Jul 29 13:22:08 -0700 2009 | link

Does heroku only let you use the official gem? i.e. can you not build your own? http://gems.github.com

If this is not possible, I would post to the thread up on the google group, as I'm not sure if ben checks these issues very often.

Comment
Does heroku only let you use the official gem? i.e. can you not build your own? http://gems.github.com If this is not possible, I would post to the thread up on the google group, as I'm not sure if ben checks these issues very often.
or cancel
bmishkin Thu Aug 06 09:13:02 -0700 2009 | link
See line 71 of lib/authlogic-oid/session.rb . When using authlogic-oid, it clears out the block:

def save(&block) block = nil if !openid_identifier.blank? super(&block) end

leaving us with no render at all, so the default create template gets loaded.

My fix is to move the render on fail outside the block in the controller, and condition it on the record saving:

render :action => "new" if @user_session.new_record? # workaround for render inside authlogic-oid
Comment
See line 71 of lib/authlogic-oid/session.rb . When using authlogic-oid, it clears out the block: def save(&block) block = nil if !openid_identifier.blank? super(&block) end leaving us with no render at all, so the default create template gets loaded. My fix is to move the render on fail outside the block in the controller, and condition it on the record saving: render :action => "new" if @user_session.new_record? # workaround for render inside authlogic-oid
or cancel
davidsf Mon Aug 10 03:18:19 -0700 2009 | link

bmishkin: Can you post your controller, please ? thx.

Comment
bmishkin: Can you post your controller, please ? thx.
or cancel
omarkarim Tue Sep 15 00:23:51 -0700 2009 | link
The following might be worth a try:

def create

@user_session = UserSession.new(params[:user_session]) @user_session.save do |result| if result flash[:notice] = "Successfully logged in." redirect_to root_url end end if !performed? # no render or redirect yet render :action => 'new' end

end
Comment
The following might be worth a try: def create @user_session = UserSession.new(params[:user_session]) @user_session.save do |result| if result flash[:notice] = "Successfully logged in." redirect_to root_url end end if !performed? # no render or redirect yet render :action => 'new' end end
or cancel
Parsed with GitHub Flavored Markdown
4.

0 votes

[feature] merge registration and login
1 comment Created 5 months ago by rubenfonseca

Title

Body
Hi. It would be very nice if it was possible to merge the login and registration together. Example: As a user who never used the website. When I login with openid. The user is automatically created. This way, I don't have a registration phase. The user simple logins, and if it doesn't exist yet on the database, the user is created. I tried to play with the existing code to implement this behavior with no success. Does it make sense?
or cancel

Hi. It would be very nice if it was possible to merge the login and registration together. Example:

As a user who never used the website.
When I login with openid.
The user is automatically created.

This way, I don't have a registration phase. The user simple logins, and if it doesn't exist yet on the database, the user is created.

I tried to play with the existing code to implement this behavior with no success. Does it make sense?

Comments

rubenfonseca Tue Jun 16 14:44:47 -0700 2009 | link

I tried to override "self.find_by_openid_identifier" on the User class as shown in http://gist.github.com/130921 .
Although it seems to work, I loose the openid registration fields since map_openid_registration is never called. I think I'm getting closer...

Comment
I tried to override "self.find_by_openid_identifier" on the User class as shown in http://gist.github.com/130921 . Although it seems to work, I loose the openid registration fields since map_openid_registration is never called. I think I'm getting closer...
or cancel

Parsed with GitHub Flavored Markdown
5.

0 votes

authlogic > 2.0.11 and authlogic_openid 1.0.4
0 comments Created 5 months ago by dbarison

Title

Body
undefined method `required_fields=' !!
or cancel

undefined method `required_fields=' !!

Comments

Parsed with GitHub Flavored Markdown
7.

0 votes

UserSession.save returns true if signing in with OpenID even when confirmed? returns false
0 comments Created 4 months ago by Bluejade

Title

Body
I originally posted this as a AuthLogic Lighthouse ticket, so I'll simply include a link to the ticket. Note that I found the cause of the problem and propose a possible solution in my second to last post in the ticket. http://binarylogic.lighthouseapp.com/projects/18752/tickets/80-usersessionsave-returns-true-if-signing-in-with-openid-even-when-confirmed-returns-false
or cancel

I originally posted this as a AuthLogic Lighthouse ticket, so I'll simply include a link to the ticket.

Note that I found the cause of the problem and propose a possible solution in my second to last post in the ticket.

http://binarylogic.lighthouseapp.com/projects/18752/tickets/80-usersessionsave-returns-true-if-signing-in-with-openid-even-when-confirmed-returns-false

Comments

Parsed with GitHub Flavored Markdown
8.

0 votes

possible "remember_me" typo in validate_by_openid method
1 comment Created 4 months ago by hugopeixoto

Title

Body
In the validate_by_openid method, you're setting the variable "self.remember_me", while a few lines below, you're using "remember_me?" (notice the question mark). I'm not completely sure if this is a typo/bug, but it looks like it. Sorry if I'm wrong.
or cancel

In the validate_by_openid method, you're setting the variable "self.remember_me", while a few lines below, you're using "remember_me?" (notice the question mark).

I'm not completely sure if this is a typo/bug, but it looks like it. Sorry if I'm wrong.

Comments

hugopeixoto Mon Aug 03 12:59:00 -0700 2009 | link

Nevermind, I just figured it out. :x

Comment
Nevermind, I just figured it out. :x
or cancel

Parsed with GitHub Flavored Markdown
9.

1 vote

Gem of new version and small issue when using in test/console..
0 comments Created 2 months ago by joost

Title

Body
Can this Github repos be turned into gem? Now I only seem to find the 1.0.4 version :( Also I get a 'nil.params?' error when using in console / test. Please see below for fix: # This fixes the following error: # You have a nil object when you didn't expect it! # The error occurred while evaluating nil.params module AuthlogicOpenid module ActsAsAuthentic module Methods def openid_complete? session_class.controller && session_class.controller.params[:open_id_complete] && session_class.controller.params[:for_model] end end end end
or cancel
Can this Github repos be turned into gem? Now I only seem to find the 1.0.4 version :(

Also I get a 'nil.params?' error when using in console / test.
Please see below for fix:
```
# This fixes the following error:
#  You have a nil object when you didn't expect it!
#  The error occurred while evaluating nil.params
module AuthlogicOpenid
  module ActsAsAuthentic
    module Methods

      def openid_complete?
        session_class.controller && session_class.controller.params[:open_id_complete] && session_class.controller.params[:for_model]
      end

    end
  end
end
```
Comments

Parsed with GitHub Flavored Markdown
10.

2 votes

auto_register tries to duplicate registration
0 comments Created 2 months ago by eimantas

Title

Body
I am trying to enable openid authentication on my website as well as use auto_register feature of latest authlogic_openid add-on. Everything works fine until second login. The first time user is created and logged in, but after I logout and try logging in into the system with same OpenID identifier I get user registration form with errors saying that username and other fields are already taken and the form is prefilled with values of earlier data passed with openid. Everything is implemented by authlogic/authlogic openid tutorial except for the user session model with new auto_register call.
or cancel

I am trying to enable openid authentication on my website as well as use auto_register feature of latest authlogic_openid add-on.

Everything works fine until second login. The first time user is created and logged in, but after I logout and try logging in into the system with same OpenID identifier I get user registration form with errors saying that username and other fields are already taken and the form is prefilled with values of earlier data passed with openid.

Everything is implemented by authlogic/authlogic openid tutorial except for the user session model with new auto_register call.

Comments

Parsed with GitHub Flavored Markdown
11.

1 vote

authlogic_openid update on rubyforge?
0 comments Created 19 days ago by daquan

Title

Body
when do we get an update on rubyforge for the gem? i'm missing the auto_register function in the gem. thx daq
or cancel

when do we get an update on rubyforge for the gem?
i'm missing the auto_register function in the gem.

thx daq

Comments

Parsed with GitHub Flavored Markdown
12.

0 votes

validation option ":if" is ignored
0 comments Created 2 days ago by bfolkens

Title

Body
For the validates_length_of_password_field_options, validates_confirmation_of_password_field_options, and validates_length_of_password_confirmation_field_options the :if option is ignored. It appears that a merge is executed against the options hash, overwriting the :if option. Can we change this to a reverse_merge? http://gist.github.com/251422 (I wanted to run this against the test suite but I couldn't get the suite to pass regardless of this patch's presence)
or cancel

For the validates_length_of_password_field_options, validates_confirmation_of_password_field_options, and validates_length_of_password_confirmation_field_options the :if option is ignored. It appears that a merge is executed against the options hash, overwriting the :if option. Can we change this to a reverse_merge? http://gist.github.com/251422

(I wanted to run this against the test suite but I couldn't get the suite to pass regardless of this patch's presence)

Comments

Parsed with GitHub Flavored Markdown

Labels

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments

Comments