Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Force ID field for all gb files converted to gff3
- Loading branch information
Nathan Liles
committed
Jul 30, 2010
1 parent
b0b52cc
commit c1abbd1
Showing
2 changed files
with
8 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1abbd1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nathan, I see that you subsequently reverted this, which is good. This probably would have been reverted by somebody else otherwise, because not all users of Bio::Tools::GFF are going to WANT a Name attribute. You should have done this in a branch, and consulted with somebody else before committing this to master.
c1abbd1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admit the patch wasn't in an ideal location to begin with. Plus, the functionality was already there and I just didn't notice. It was a hatchet job. My bad.
c1abbd1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eh, it happens. No worries.