New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ip IsInternal() to account for missed ranges #827

Merged

kspearrin merged 2 commits into master from ipfix

Jul 18, 2020

Member

kspearrin commented Jul 17, 2020

Report from HackerOne pointed out a few more ranges, including IPv6, that we are missing on our IsInternal check to prevent SSRF attacks.


          update ip IsInternal() to account for missed ranges

52554d0

kspearrin requested a review from a team

July 17, 2020 15:51

cscharf previously approved these changes

View reviewed changes

Contributor

cscharf left a comment

Looks good, waiting on review/final comments from polict of Shielder.


          update with ::

129af9d

kspearrin dismissed cscharf’s stale review via

129af9d

July 18, 2020 12:07

kspearrin merged commit 036b402 into master

kspearrin deleted the ipfix branch

July 18, 2020 12:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment