Issues - blaine/xmpp4r-simple

blaine / xmpp4r-simple

Description:

Jabber::Simple

Sort by: Priority | Votes | Last Updated

Loading…

1.

1 vote

Deferred message delivery spikes CPU usage to 100%
2 comments Created 7 months ago by mtodd

Title

Body
This is directly related to: http://code.google.com/p/xmpp4r-simple/issues/detail?id=7#makechanges The culprit is start_deferred_delivery_thread with the following code: def start_deferred_delivery_thread #:nodoc: Thread.new { loop { messages = [queue(:pending_messages).pop].flatten messages.each do |message| if subscribed_to?(message[:to]) deliver(message[:to], message[:message], message[:type]) else queue(:pending_messages) << message end end } } end The loop has absolutely no sleep time and will run at max speed, continually dequeueing and queueing until there is no more CPU power left, then it keeps going until nothing else runs on your computer (unless you've got god/monit monitoring it) until the subscription actually occurs. In my production environment, this is asynchronous, and can occur even upwards of days later, and I'd rather not have my CPU raped for that long.
or cancel
This is directly related to:

http://code.google.com/p/xmpp4r-simple/issues/detail?id=7#makechanges

The culprit is start_deferred_delivery_thread with the following code:
```
def start_deferred_delivery_thread #:nodoc:
Thread.new {
  loop {
    messages = [queue(:pending_messages).pop].flatten
    messages.each do |message|
      if subscribed_to?(message[:to])
        deliver(message[:to], message[:message], message[:type])
      else
        queue(:pending_messages) << message
      end
    end
  }
}
```
end

The loop has absolutely no sleep time and will run at max speed, continually dequeueing and queueing until there is no more CPU power left, then it keeps going until nothing else runs on your computer (unless you've got god/monit monitoring it) until the subscription actually occurs.

In my production environment, this is asynchronous, and can occur even upwards of days later, and I'd rather not have my CPU raped for that long.
Comments

mtodd Wed Apr 22 14:21:47 -0700 2009 | link

Committed quick fix and submitted pull request with tests.

Comment
Committed quick fix and submitted pull request with tests.
or cancel

mtodd Thu Apr 23 10:56:12 -0700 2009 | link

http://github.com/mtodd/xmpp4r-simple just in case you want to inspect my patch

Comment
http://github.com/mtodd/xmpp4r-simple just in case you want to inspect my patch
or cancel

Parsed with GitHub Flavored Markdown
2.

0 votes

test_add_users_to_our_roster_should_succeed_with_automatic_approval reliably fails
0 comments Created 7 months ago by mtodd

Title

Body
The test test_add_users_to_our_roster_should_succeed_with_automatic_approval reliably fails around line 107 (assertion that client2 is subscribed to client1). I'm not able to get this to pass. I have xmpp4r-simple 0.8.8 and xmpp4r 0.4 installed.
or cancel

The test test_add_users_to_our_roster_should_succeed_with_automatic_approval reliably fails around line 107 (assertion that client2 is subscribed to client1).

I'm not able to get this to pass.

I have xmpp4r-simple 0.8.8 and xmpp4r 0.4 installed.

Comments

Parsed with GitHub Flavored Markdown
3.

0 votes

Problem with tests and adding incorrect JIDs to roster
0 comments Created 7 months ago by mtodd

Title

Body
I've noticed that occasionally, in some situations, the tests that add clients to the roster, instead of adding test1@domain.com, will add #<jabber::simple:0x0xxxxxx> as the JID. This is obviously wrong. I was not able to pinpoint where exactly the problem was originating from (which tests, specifically). I'm on xmpp4r-simple 0.8.8 (latest gem version) and xmpp4r 0.4.
or cancel

I've noticed that occasionally, in some situations, the tests that add clients to the roster, instead of adding test1@domain.com, will add #<jabber::simple:0x0xxxxxx> as the JID. This is obviously wrong.

I was not able to pinpoint where exactly the problem was originating from (which tests, specifically).

I'm on xmpp4r-simple 0.8.8 (latest gem version) and xmpp4r 0.4.

Comments

Parsed with GitHub Flavored Markdown
4.

1 vote

Testing instability
0 comments Created 7 months ago by mtodd

Title

Body
There are several problems with the approach to testing; admittedly, Jabber isn't an easy protocol to test, but I believe every single one of the features involved in xmpp4r-simple should be mocked to include no networking, and certainly no real Jabber accounts. This would resolve intermittent errors due to network latency et al. It would also make writing further tests much simpler (and therefore more probable). Also, it will help with having to deal with side-effects of previous tests (if there are any) due to the external dependency. Personally, it's painful and disheartening to sit there with the tests failing due to network problems, especially when they sit there for 20 seconds for each network-sensitive test.
or cancel

There are several problems with the approach to testing; admittedly, Jabber isn't an easy protocol to test, but I believe every single one of the features involved in xmpp4r-simple should be mocked to include no networking, and certainly no real Jabber accounts.

This would resolve intermittent errors due to network latency et al. It would also make writing further tests much simpler (and therefore more probable). Also, it will help with having to deal with side-effects of previous tests (if there are any) due to the external dependency.

Personally, it's painful and disheartening to sit there with the tests failing due to network problems, especially when they sit there for 20 seconds for each network-sensitive test.

Comments

Parsed with GitHub Flavored Markdown
5.

1 vote

[PATH] Add ability to register new users with the jabber server
0 comments Created 7 months ago by mtodd

Title

Body
Originally submitted by saimonmoore with a path included; please refer to http://code.google.com/p/xmpp4r-simple/issues/detail?id=6#makechanges Simple usage: im = Jabber::Simple.register(jid, passwd) * will try and register user on the server * if successfull, will reconnect and send default status presence * if not successfull, throws a RegistrationError with a detailed message #self.register method signature: self.register(jid, password, status = nil, status_message = "Available") #So you can still provide custom status after registration
or cancel
Originally submitted by saimonmoore with a path included; please refer to http://code.google.com/p/xmpp4r-simple/issues/detail?id=6#makechanges

Simple usage:

im = Jabber::Simple.register(jid, passwd)
- will try and register user on the server
- if successfull, will reconnect and send default status presence
- if not successfull, throws a RegistrationError with a detailed message
self.register method signature:

self.register(jid, password, status = nil, status_message = "Available") #So you can still provide
custom status after registration
Comments

Parsed with GitHub Flavored Markdown

Labels

Deferred message delivery spikes CPU usage to 100%

Comments

test_add_users_to_our_roster_should_succeed_with_automatic_approval reliably fails

Comments

Problem with tests and adding incorrect JIDs to roster

Comments

Testing instability

Comments

[PATH] Add ability to register new users with the jabber server

self.register method signature:

Comments