@@ -35,7 +35,7 @@ import org.jboss.xb.util.JBossXBHelper; public abstract class JBossXBDeployer<T> extends UnmarshallerFactoryDeployer<T, Boolean> { /** The helper */ - private JBossXBHelper<T> helper; + private final JBossXBHelper<T> helper; /** * Create a new SchemaResolverDeployer. @@ -46,6 +46,17 @@ public abstract class JBossXBDeployer<T> extends UnmarshallerFactoryDeployer<T, public JBossXBDeployer(Class<T> output) { super(output); + helper = createHelper(); + } + + /** + * Create the helper. + * + * @return new helper instance + */ + protected JBossXBHelper<T> createHelper() + { + return new JBossXBHelper<T>(getOutput()); } /** @@ -55,9 +66,6 @@ public abstract class JBossXBDeployer<T> extends UnmarshallerFactoryDeployer<T, */ protected JBossXBHelper<T> getHelper() { - if (helper == null) - helper = new JBossXBHelper<T>(getOutput()); - return helper; } deployers-vfs-spi/src/main/java/org/jboss/deployers/vfs/spi/deployer/JBossXBDeployer.java 43066d731847ff2f5e8f101fa4985b9fed76cf94 alesj alesj@84be2c1e-ba19-0410-b317-a758671a6fc1 http://github.com/bobmcwhirter/jboss-deployers/commit/58da76c058cc44bdaa883cd1b72825e87eb97c56 58da76c058cc44bdaa883cd1b72825e87eb97c56 2009-07-01T05:13:05-07:00 2009-07-01T05:13:05-07:00 [JBDEPLOY-202]; create helper in ctor to avoid any concurrency issues. git-svn-id: http://anonsvn.jboss.org/repos/jbossas/projects/jboss-deployers/trunk@90743 84be2c1e-ba19-0410-b317-a758671a6fc1 397a9e82bdca612c368974e311d3f2f9b10a3b46 alesj alesj@84be2c1e-ba19-0410-b317-a758671a6fc1