Issues - bogolisk/egg

bogolisk / egg

111

Description:

Emacs Got Git. This is a clone of Marius's excellent magit. Egg is an emacs interface to git.

Sort by: Priority | Votes | Last Updated

Loading…

1.

0 votes

Blame / 1.6.5.1 : can't find "^summary "
1 comment Created about 1 month ago by mkleehammer

Title

Body
A recent version of git seems to have switched the order of the filename and summary tokens in the blame porcelain format. This causes egg to skip every other commit and fail at the end of the file because it can't find "^summary ". I've patched it locally to fix this by simply switching the searches. I don't know if that is a real fix since I don't know if the format is now stable. You might need to always re-search from the hash position. BTW, thanks for egg. It is a fantastic piece of software.
or cancel

A recent version of git seems to have switched the order of the filename and summary tokens in the blame porcelain format. This causes egg to skip every other commit and fail at the end of the file because it can't find "^summary ".

I've patched it locally to fix this by simply switching the searches. I don't know if that is a real fix since I don't know if the format is now stable. You might need to always re-search from the hash position.

BTW, thanks for egg. It is a fantastic piece of software.

Comments

mkleehammer Sat Nov 07 19:14:36 -0800 2009 | link

I'm pretty sure the "guilty party" is this:

http://git.kernel.org/?p=git/git.git;a=commit;h=9991030c0c97285087e5da86cfdbaf143a8a74cb

It looks like all of the tokens except filename were extracted to a common function. This means that filename will now always be last.

Comment
I'm pretty sure the "guilty party" is this: http://git.kernel.org/?p=git/git.git;a=commit;h=9991030c0c97285087e5da86cfdbaf143a8a74cb It looks like all of the tokens except filename were extracted to a common function. This means that filename will now always be last.
or cancel

Parsed with GitHub Flavored Markdown
2.

1 vote

No tags/refs in log buffer w/ git 1.6
1 comment Created about 1 month ago by mkleehammer

Title

Body
Tags and refs no longer show up in the log buffer, and I'm pretty sure it coincided with a recent 1.6 install. I have confirmed that they are being provided and are properly parsed in egg-decorate-log, but they aren't being inserted with the dashes. I wanted to provide patch, but my elisp skills apparently need work. What code, exactly, should insert them into the buffer?
or cancel
Tags and refs no longer show up in the log buffer, and I'm pretty sure it coincided with a recent 1.6 install.

I have confirmed that they are being provided and are properly parsed in egg-decorate-log, but they aren't being inserted with the dashes. I wanted to provide patch, but my elisp skills apparently need work. What code, exactly, should insert them into the buffer?

Comments
mkleehammer Wed Nov 11 08:40:38 -0800 2009 | link
It seems to be this:

(setq ref-string (if full-refs (propertize (mapconcat (lambda (full-ref-name) (cdr (assoc full-ref-name dec-ref-alist))) full-refs separator) :navigation sha1 :commit sha1 :references refs)))

This creates an empty string. Apparently dec-ref-alist doesn't contain the refs? I haven't had time to look into this. In a local copy I simply replaced the assoc lookup with the original name. (Basically just concatenated the original names.)
Comment
It seems to be this: (setq ref-string (if full-refs (propertize (mapconcat (lambda (full-ref-name) (cdr (assoc full-ref-name dec-ref-alist))) full-refs separator) :navigation sha1 :commit sha1 :references refs))) This creates an empty string. Apparently dec-ref-alist doesn't contain the refs? I haven't had time to look into this. In a local copy I simply replaced the assoc lookup with the original name. (Basically just concatenated the original names.)
or cancel
Parsed with GitHub Flavored Markdown

Labels

Blame / 1.6.5.1 : can't find "^summary "

Comments

No tags/refs in log buffer w/ git 1.6

Comments