New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update config.hpp #36
Conversation
For ticket# 6766
Hi, Would you please tell me if the branch tractickets/6766-incorrect-declaration-for-putenv-in-config.hpp corrects the issue? Thanks, |
I'm not clear on what needs to be verified.
I looked at
0f95ca8
and it looks OK.
If I need to check on something else, do let me know. I will do so.
Thanks.
|
The idea is that you checkout this branch |
I'm not familiar with git. How do I check out this branch?
Could you point me to some documentation on it, if possible?
Thanks.
|
Let's call
|
Thanks, I will clone the repository and follow the steps, test and report back here.
|
Ok thanks. If you clone, you have to do the following before the commands I sent above
|
Yes, will do. Thanks. |
I have tested the changes. It looks good. Thanks. |
Thanks, I merge the changes to develop once we have a slot. |
Thank you, truly appreciate your help on this ticket(#6766). It has been around for 3 years and getting this into 1.58 would mean around 15% improvement in the pass rate for the test runs with our compiler.
|
Any idea when the slot would be open to merge? |
Merged to develop |
For ticket# 6766