Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.hpp #36

Closed
wants to merge 1 commit into from
Closed

Update config.hpp #36

wants to merge 1 commit into from

Conversation

akumta
Copy link
Contributor

@akumta akumta commented Mar 3, 2015

For ticket# 6766

For ticket# 6766
@raffienficiaud
Copy link
Member

Hi,

Would you please tell me if the branch tractickets/6766-incorrect-declaration-for-putenv-in-config.hpp corrects the issue?
I rebased your patch onto 0f34822

Thanks,
Raffi

@akumta
Copy link
Contributor Author

akumta commented Mar 23, 2015 via email

@raffienficiaud
Copy link
Member

The idea is that you checkout this branch tractickets/6766-incorrect-declaration-for-putenv-in-config.hpp and test it. I added some changes to your PR.

@akumta
Copy link
Contributor Author

akumta commented Mar 23, 2015 via email

@raffienficiaud
Copy link
Member

Let's call $boost your boost clone:

cd $boost/libs/test
git fetch
git checkout tractickets/6766-incorrect-declaration-for-putenv-in-config.hpp

@akumta
Copy link
Contributor Author

akumta commented Mar 23, 2015 via email

@raffienficiaud
Copy link
Member

Ok thanks. If you clone, you have to do the following before the commands I sent above

git clone https://github.com/boostorg/boost.git
git submodule init
git submodule update --recursive

@akumta
Copy link
Contributor Author

akumta commented Mar 23, 2015

Yes, will do. Thanks.

@akumta
Copy link
Contributor Author

akumta commented Mar 24, 2015

I have tested the changes. It looks good. Thanks.

@raffienficiaud
Copy link
Member

Thanks, I merge the changes to develop once we have a slot.

@akumta
Copy link
Contributor Author

akumta commented Mar 24, 2015 via email

@akumta
Copy link
Contributor Author

akumta commented Mar 25, 2015

Any idea when the slot would be open to merge?

@raffienficiaud
Copy link
Member

Merged to develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants