app/models/platform.rb app/views/comments/_comment.html.erb app/views/comments/_failed_comment.html.erb app/views/comments/_new.html.erb app/views/comments/_working_comment.html.erb db/migrate/20090202151412_create_platforms.rb db/migrate/20090202155040_add_various_indexes.rb test/unit/platform_test.rb @@ -10,6 +10,7 @@ class CodesController < ApplicationController def show @code = Code.find_by_slug_name!(params[:slug_name]) + @comment = Comment.new rescue ActiveRecord::RecordNotFound @codes = Code.find_with_ferret(["*", params[:slug_name], "*"].to_s) app/controllers/codes_controller.rb @@ -1,2 +1,13 @@ class CommentsController < ApplicationController + def create + @code = Code.find params[:code_id] + @comment = @code.build_comment params[:comment] + @comment.save! + flash[:notice] = 'Thanks for your comment' + redirect_to code_by_slug_path(@code.slug_name) + + rescue ActiveRecord::RecordInvalid + render :template => 'codes/show' + flash[:error] = 'Sorry, unable to save your comment' + end end app/controllers/comments_controller.rb @@ -1,2 +1,9 @@ module CommentsHelper + def name_link_for comment + if comment.url.blank? + h(comment.name) + else + "<a href=\"#{h(comment.url)}\">#{h(comment.name)}</a>" + end + end end app/helpers/comments_helper.rb @@ -1,20 +1,10 @@ class Code < ActiveRecord::Base - - named_scope :last_thirty_active, :order => "updated_at DESC", :limit => 30 - - validates_uniqueness_of :name, :slug_name - validates_presence_of :name, :slug_name - has_many :authorships has_many :authors, :through => :authorships - has_many :comments, :dependent => :destroy + has_many :comments, :dependent => :destroy, :order => 'created_at desc' has_many :working_comments, :class_name => 'Comment', :conditions => { :works_for_me => true } has_many :failure_comments, :class_name => 'Comment', :conditions => { :works_for_me => false } - acts_as_ferret :fields => [:name, :description, :homepage, :rubyforge, :github, :slug_name] - - before_validation_on_create :set_slug_name - def works? has_no_failure_comments? && has_working_comments? end @@ -43,6 +33,13 @@ class Code < ActiveRecord::Base private + validates_uniqueness_of :name, :slug_name + validates_presence_of :name, :slug_name + + before_validation_on_create :set_slug_name + + acts_as_ferret :fields => [:name, :description, :homepage, :rubyforge, :github, :slug_name] + def set_slug_name self.slug_name = slug_name_from_name || self.rubyforge end app/models/code.rb @@ -1,3 +1,8 @@ class Comment < ActiveRecord::Base belongs_to :code + belongs_to :platform + +private + validates_presence_of :code + validates_presence_of :platform end app/models/comment.rb @@ -10,4 +10,13 @@ <p class="authors"> <%= h @code.author_names %> -</p> \ No newline at end of file +</p> + +<p><%= link_to_function 'add a comment &rarr;', visual_effect(:toggle_blind, 'new-comment-form') %> </p> +<div id="new-comment-form" style="display:none"> + <%= render :partial => 'comments/new', :locals => { :code => @code } %> +</div> + + +<%= render :partial => 'comments/comment', :collection => @code.comments %> + app/views/codes/show.html.erb @@ -29,6 +29,9 @@ <% unless flash[:notice].blank? %> <div id="flash_notice"> <%= flash[:notice] %> </div> <% end %> + <% unless flash[:error].blank? %> + <div id="flash_error"> <%= flash[:error] %> </div> + <% end %> &nbsp; <% form_tag codes_path, :method => :get, :id => 'search-form' do %> <%= text_field_tag :search, params[:search] %> <%= submit_tag 'Search &rarr;', :disable_with => 'searching....' %> app/views/layouts/isitruby19.html.erb @@ -1,7 +1,7 @@ class CreateCodes < ActiveRecord::Migration def self.up create_table :codes do |t| - t.string :name, :description, :homepage, :rubyforge, :github, :type + t.string :name, :description, :homepage, :rubyforge, :github, :type, :slug_name t.decimal :latest_version t.timestamps end db/migrate/20090131234053_create_codes.rb @@ -1,12 +1,14 @@ class CreateComments < ActiveRecord::Migration def self.up create_table :comments do |t| - t.references :code, :user + t.references :code, :platform t.text :body t.boolean :works_for_me - t.string :platform + t.string :name, :url t.timestamps end + + add_index :comments, :code_id end def self.down db/migrate/20090131234059_create_comments.rb @@ -9,7 +9,7 @@ # # It's strongly recommended to check this file into your version control system. -ActiveRecord::Schema.define(:version => 20090202123742) do +ActiveRecord::Schema.define(:version => 20090202155040) do create_table "authors", :force => true do |t| t.string "name" @@ -17,6 +17,8 @@ ActiveRecord::Schema.define(:version => 20090202123742) do t.datetime "updated_at" end + add_index "authors", ["name"], :name => "index_authors_on_name" + create_table "authorships", :force => true do |t| t.integer "author_id" t.integer "code_id" @@ -24,6 +26,9 @@ ActiveRecord::Schema.define(:version => 20090202123742) do t.datetime "updated_at" end + add_index "authorships", ["author_id"], :name => "index_authorships_on_author_id" + add_index "authorships", ["code_id"], :name => "index_authorships_on_code_id" + create_table "codes", :force => true do |t| t.string "name" t.string "description" @@ -31,36 +36,35 @@ ActiveRecord::Schema.define(:version => 20090202123742) do t.string "rubyforge" t.string "github" t.string "code_type" + t.string "slug_name" t.decimal "latest_version" t.datetime "created_at" t.datetime "updated_at" - t.string "slug_name" end + add_index "codes", ["name"], :name => "index_codes_on_name" + add_index "codes", ["updated_at"], :name => "index_codes_on_updated_at" + create_table "comments", :force => true do |t| t.integer "code_id" - t.integer "user_id" + t.integer "platform_id" t.text "body" t.boolean "works_for_me" - t.string "platform" + t.string "name" + t.string "url" t.datetime "created_at" t.datetime "updated_at" end - create_table "users", :force => true do |t| + add_index "comments", ["code_id"], :name => "index_comments_on_code_id" + add_index "comments", ["created_at"], :name => "index_comments_on_created_at" + + create_table "platforms", :force => true do |t| t.string "name" - t.string "email" - t.string "homepage" - t.string "login", :null => false - t.string "crypted_password", :null => false - t.string "password_salt", :null => false - t.string "persistence_token", :null => false - t.string "single_access_token", :null => false - t.string "perishable_token", :null => false - t.integer "login_count", :default => 0, :null => false t.datetime "created_at" t.datetime "updated_at" - t.boolean "is_admin" end + add_index "platforms", ["name"], :name => "index_platforms_on_name" + end db/schema.rb @@ -3,4 +3,8 @@ namespace :isitruby19 do task :import => :environment do GemImporter.import end + + task :load_platforms => :environment do + Platform.load_defaults + end end \ No newline at end of file lib/tasks/isitruby19.rake db/migrate/20090131234446_create_users.rb db/migrate/20090201000927_add_slug_to_codes.rb 05710fe4e78a739a2ab85db9f69d913df0279c6a Rahoul Baruah rahoul@brightbox.co.uk http://github.com/brightbox/isitruby19/commit/d1d730a655ca6d7eeb2c1bea9628d4efaba2dc42 d1d730a655ca6d7eeb2c1bea9628d4efaba2dc42 2009-02-02T07:54:16-08:00 2009-02-02T07:54:16-08:00 basic commenting in place 8e4085faaff0b64994c899fc259289d6b3eacb7b Rahoul Baruah rahoul@brightbox.co.uk