Comments for brynary's webrat  

This change actually breaks all my selenium tests where I'm searching for a label.
fill_in("Name:", :with => name) now fails but
fill_in("student_name", :with => name) works (basically using the id of the textfield still works).

breaks tests that set @value with a string that has a newline

Aha, note to anyone else who ever reads this: you have to use click_area instead of click_link. Use id or title to reference the area you want clicked.

I notice the mention of image map support in the history. Does this mean that webrat supports clicking on map areas? Is it as simple as using click_link?

I think the changes in the canonicalize_all_urls branch of my fork would remove the need for this, as it makes all urls into fully-qualified absolute urls before requesting them.

Hey guys,

Sorry I wasn’t able to get the outstanding patches merged in for this release. It was very directly motivated by needing the have_selector changes released to match what we’re talking about in the latest RSpec Book beta release. There will be another release soon with the things you guys mentioned.

Cheers,

-Bryan

So sad that the options passed to selenium isn’t going in.

Too bad you didn’t include the Sinatra fixes. ttyl later tonight on rack-test :)

Ahh. I was looking and assert_have_tag doesn’t conflict with Rails. The Rails assert is assert_tag. Is there any other reason why the original commit was rolled back?

Amos — We had to roll back the inclusion of have_tag by default into non-Merb environments, which caused this test to start failing. Mike disabled the tests as a quick fix to get “rake precommit” back to a passing state.

Having this test is fine, but we’ll need to update the integration app to manually include the have_tag matcher.

Why turn off the test. This is currently a working feature. Turning off the test until you decide if we want the feature doesn’t help. I don’t get it.

This will not work in selenium mode. At least not yet. =8-)

And what if you want to run your tests in selenium mode (or another new mode)? Such features will make it harder to maintain the code base. I thought a main goal is to keep it possible to run the webrat tests in multiple modes? I think the public webrat api should be web framework agnostic.

BTW: I think for a rails guy it’s not a big deal to write “within(dom_id(user))” ;-)

WDYT?

Hey, did you ever add a way to get a hold of the redirect location in a platform independent way?

Yeah its a bit confusing as Webrat is a dependency of Merb so the support is built into the core somewhere.

Right. So I supposed it was this easy, but since I didn’t find a require “webrat” anywhere I was trying to figure where the magic was :)

No prob, I have this crazy idea of being able to make a little movie from a story, perhaps with the story text as subtitles…

This is awesome, thanks for adding it! I was just wishing for something just like this today…

Is the reload/reloads deprecation intentionally the opposite of the rest?

I patched MechanizeSession so that it ensures that the URL is absolute. Here’s the commit.