Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Extending ActionController::IntegrationTest instead of ActionControll…
…er::Integration::Session fixes error with Webrat's select method
- Loading branch information
Showing
3 changed files
with
7 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f530cf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rails.rb:82 “class IntegrationTest” causes “action_controller/integration.rb:583: superclass mismatch for class IntegrationTest”. Should it be “class IntegrationTest < Test::Unit::TestCase”?
4f530cf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the same problem.
4f530cf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems only to be an issue when using as plugin. The gem works okay (something to do with the loading order maybe?).
4f530cf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch.
I just pushed a commit that should resolve this by adding a require statement. Also, I switched to using class_eval which will fail fast if the class isn’t defined rather than potentially defining a class if it isn’t found.