Comments for bsag's tracks  

onenote urls keep working. need to create test for onenote url's

no sweat :-)

Whoops! Should've caught those myself. Thanks, Reiner.

how did you find it? nice find.

For the first one, it looks like the test is right and update_state_from_project isn’t getting called on the todo under test. Sounds like a bug to me.

The second bug is strange—assigns[‘project_not_done_counts’] doesn’t appear to be set anywhere in TodosController, and yet it’s got a value in the test. I’m not sure what’s going on.

This introduces two test failures: test_todo_state_is_project_hidden_after_hiding_project and test_not_done_counts_after_hiding_project. Is the test or the code broken?

Looks like there was a problem with line endings or white spaces in todo.rb.

Few improvements:

[] – empty array Clear Taggings table Tagging.delete_all

Actually, this command didn’t work for me when I tried it on a fresh checkout. “git submodule init doc/manual & git submodule update doc/manual” did.

Will fix this myself this evening.

well, if you can show me how to keep git (on windows) to work correctly with CR LF vs LF… setting the core.autocrlf often does not work at all…

Looks like we have some inconsistency with line endings. Is there an official standard for Tracks about CR-LF vs. LF? I usually just save files as whatever I opened them as, but then slip-ups like this happen where git thinks the entire file changed

is the in_time_zone error solved now or do you still have that problem?

AARGH, sorry, i did not migrated correctly – my mistake. Sorry for noise.

I will submit path for this as I found another small things after the upgrade

I get undefined method in_time_zone after this change.

More on error:

Showing todos/_todo.html.erb where line #15 raised:

undefined method `in_time_zone’ for Fri, 05 Sep 2008:Date

Extracted source (around line #15):

12: <%= remote_toggle_checkbox unless source_view_is :deferred > 13: = staleness_class( todo ) >"> 14: < unless @todo.completed? ><= defer_link(1) > <= defer_link(7) >< end > 15: <= date_span -%> 16: <%= h sanitize(todo.description) > 17: <= link_to(image_tag(“recurring16x16.png”), {:controller => “recurring_todos”, :action => "index"}, :class => “recurring_icon”) if @todo.from_recurring_todo? > 18: <= tag_list %>

Trace of template inclusion: /contexts/_context.rhtml, /todos/index.html.erb

RAILS_ROOT: /var/web/kub.cz/diar/tracks Application Trace | Framework Trace | Full Trace

app/controllers/application.rb:118:in `format_date’ (eval):2:in `send’ (eval):2:in `format_date’ app/helpers/application_helper.rb:55:in `due_date’ app/helpers/todos_helper.rb:99:in `date_span’ app/views/todos/todo.html.erb:15:in `run_erb_47app47views47todos47_todo46html46erb’ app/views/contexts/context.rhtml:39:in `_run_erb47app47views47contexts47context46rhtml’ (_DELEGATION__):2:in `map’ (DELEGATION):2:in `__send__’ (DELEGATION):2:in `map’ app/views/todos/index.html.erb:4:in `run_erb_47app47views47todos47index46html46erb’ app/controllers/todos_controller.rb:705:in `render_todos_html’ app/controllers/todoscontroller.rb:19:in `index’

this one needs a rake db:migrate

thanks for the feedback!

Tested on iPhone. Tab order is correct from top down now. Thank you!

yes, true. We forgot that for the 1.6 release. We should do this before releasing 1.7

maybe we should rename tracks-15* to tracks-17* ? (and generally, have the appropriate filename for each release)