bsag / tracks fork watch download tarball
public
Forks72Right
Watchers222Right
Description: Tracks is a GTD(TM) web application, built with Ruby on Rails
Homepage: http://www.rousette.org.uk/projects/
Clone URL: git://github.com/bsag/tracks.git
Click here to lend your support to: tracks and make a donation at www.pledgie.com ! 
fix #789 by setting tab order for all elements in mobile edit form

I do not have an iPhone to test so I cannot check the report. Please report if 
the fix is wrong
lrbalt (author)
Sun Nov 09 02:15:49 -0800 2008
commit  793f43ef07b823b274aed578ec63b2b4c761d337
tree    76342db305c39634587e2496146d44fc3bed207a
parent  f21908a2a0bf349dee694ba971b23a7d5f7e9984
0
app/views/todos/_edit_mobile.rhtml 
...
33
34
35
36
37
 
 
38
39
40
 
 
 
...
33
34
35
 
 
36
37
38
 
 
39
40
 
0
@@ -33,8 +33,8 @@ end %>
0
 <h2><label for="tag_list">Tags (separate with commas)</label></h2>
0
 <%= text_field_tag "tag_list", @tag_list_text, :size => 30, :tabindex => 6 %> 
0
 <h2><label for="todo_due">Due</label></h2>
0
-<%= date_select("todo", "due", :order => [:day, :month, :year],
0
-                    :start_year => this_year, :include_blank => true) %>
0
+<%= date_select("todo", "due", {:order => [:day, :month, :year],
0
+                    :start_year => this_year, :include_blank => true}, :tabindex => 7) %>
0
 <h2><label for="todo_show_from">Show from</label></h2>
0
-<%= date_select("todo", "show_from", :order => [:day, :month, :year], 
0
-                    :start_year => this_year, :include_blank => true) %>
0
+<%= date_select("todo", "show_from", {:order => [:day, :month, :year], 
0
+                    :start_year => this_year, :include_blank => true}, :tabindex => 8) %>
0
app/views/todos/new.m.erb 
...
1
2
3
 
4
5
6
 
...
1
2
 
3
4
5
6
 
0
@@ -1,5 +1,5 @@
0
 <% form_tag formatted_todos_path(:m), :method => :post do %>
0
   <%= render :partial => 'edit_mobile' %>
0
-  <p><input type="submit" value="Create" tabindex="6" accesskey="#" /></p>
0
+  <p><input type="submit" value="Create" tabindex="12" accesskey="#" /></p>
0
 <% end -%>
0
 <%= link_to "Back", @return_path %>
0
\ No newline at end of file

Comments

ridizy Mon Nov 10 06:33:26 -0800 2008

Tested on iPhone. Tab order is correct from top down now. Thank you!

lrbalt Tue Nov 11 06:37:42 -0800 2008

thanks for the feedback!

Parsed with GitHub Flavored Markdown